feat(ast_tools): allow attrs on types which do not derive the trait#8874
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Conversation
This was referenced Feb 3, 2025
Member
Author
This was referenced Feb 3, 2025
5bf3d6e to
0a8303d
Compare
c4e297d to
7a74484
Compare
This was referenced Feb 3, 2025
0a8303d to
8c6d877
Compare
7a74484 to
dd71d68
Compare
Contributor
Merge activity
|
8c6d877 to
7ddd219
Compare
dd71d68 to
f40f494
Compare
Base automatically changed from
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
to
main
February 4, 2025 03:39
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Generally, custom attributes relating to a trait e.g.
CloneIn/#[clone_in]are only legal if the trait is derived on the type. Allow aDeriveto choose to relax this restriction. This is necessary for #8875, #8876, and #8877.