Skip to content

refactor(ast_tools): parse attributes more deeply#8881

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_tools_parse_attributes_more_deeply
Feb 4, 2025
Merged

refactor(ast_tools): parse attributes more deeply#8881
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_tools_parse_attributes_more_deeply

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of syn types from code generators - they now work entirely with oxc_ast_tools's types (which are simpler).

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 20:26
@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_derive_contenteq_on_literal_types branch from b4e18ef to f22c5d3 Compare February 3, 2025 21:59
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from 1bf4794 to c09d4f6 Compare February 3, 2025 22:00
@Boshen Boshen changed the base branch from 02-03-refactor_ast_derive_contenteq_on_literal_types to graphite-base/8881 February 4, 2025 02:55
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from c09d4f6 to d7945c7 Compare February 4, 2025 09:26
@overlookmotel overlookmotel changed the base branch from graphite-base/8881 to main February 4, 2025 09:26
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of `syn` types from code generators - they now work entirely with `oxc_ast_tools`'s types (which are simpler).
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from 3f1006b to 2eb6594 Compare February 4, 2025 22:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@graphite-app graphite-app bot merged commit 2eb6594 into main Feb 4, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch February 4, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant