refactor(ast_tools): parse attributes more deeply#8881
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Merged
refactor(ast_tools): parse attributes more deeply#8881graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Feb 3, 2025
Member
Author
This was referenced Feb 3, 2025
b4e18ef to
f22c5d3
Compare
1bf4794 to
c09d4f6
Compare
f22c5d3 to
a302e32
Compare
c09d4f6 to
d7945c7
Compare
This was referenced Feb 4, 2025
d7945c7 to
3f1006b
Compare
Contributor
Merge activity
|
After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of `syn` types from code generators - they now work entirely with `oxc_ast_tools`'s types (which are simpler).
3f1006b to
2eb6594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of
syntypes from code generators - they now work entirely withoxc_ast_tools's types (which are simpler).