refactor(ast): move #[estree(skip)] to types#8877
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Merged
Conversation
This was referenced Feb 3, 2025
Member
Author
CodSpeed Performance ReportMerging #8877 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
174ddbe to
4c4f808
Compare
00d3f39 to
3df6dae
Compare
This was referenced Feb 3, 2025
4c4f808 to
b1e3cb1
Compare
3df6dae to
3c771fc
Compare
Contributor
Merge activity
|
Similar to #8876. Remove `#[estree(skip)]` attributes from struct fields containing semantic IDs, and add that attribute to the `ScopeId`, `SymbolId` and `ReferenceId` types instead. This reduces pointless repetition in the AST type definitions.
b1e3cb1 to
3407d47
Compare
3c771fc to
6628e1d
Compare
Base automatically changed from
02-03-refactor_ast_move_clone_in_default_to_types
to
main
February 4, 2025 03:48
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similar to #8876. Remove
#[estree(skip)]attributes from struct fields containing semantic IDs, and add that attribute to theScopeId,SymbolIdandReferenceIdtypes instead. This reduces pointless repetition in the AST type definitions.