Skip to content

refactor(ast): move #[estree(skip)] to types#8877

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_move_estree_skip_to_types
Feb 4, 2025
Merged

refactor(ast): move #[estree(skip)] to types#8877
graphite-app[bot] merged 1 commit intomainfrom
02-03-refactor_ast_move_estree_skip_to_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

Similar to #8876. Remove #[estree(skip)] attributes from struct fields containing semantic IDs, and add that attribute to the ScopeId, SymbolId and ReferenceId types instead. This reduces pointless repetition in the AST type definitions.

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 19:07
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8877 will create unknown performance changes

Comparing 02-03-refactor_ast_move_estree_skip_to_types (6628e1d) with 02-03-refactor_ast_move_clone_in_default_to_types (3407d47)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 24.8 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 723.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.5 µs N/A
🆕 lexer[antd.js] N/A 22 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 298.5 µs N/A
🆕 mangler[typescript.js] N/A 40 ms N/A
🆕 minifier[antd.js] N/A 157.4 ms N/A
🆕 minifier[react.development.js] N/A 1.6 ms N/A
🆕 minifier[typescript.js] N/A 270 ms N/A
🆕 estree[checker.ts] N/A 207.5 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.5 µs N/A
🆕 parser[antd.js] N/A 106.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_clone_in_default_to_types branch from 174ddbe to 4c4f808 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 00d3f39 to 3df6dae Compare February 3, 2025 20:23
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_clone_in_default_to_types branch from 4c4f808 to b1e3cb1 Compare February 3, 2025 21:58
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 3df6dae to 3c771fc Compare February 3, 2025 21:58
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

Similar to #8876. Remove `#[estree(skip)]` attributes from struct fields containing semantic IDs, and add that attribute to the `ScopeId`, `SymbolId` and `ReferenceId` types instead. This reduces pointless repetition in the AST type definitions.
graphite-app bot pushed a commit that referenced this pull request Feb 4, 2025
…8874)

Generally, custom attributes relating to a trait e.g. `CloneIn` / `#[clone_in]` are only legal if the trait is derived on the type. Allow a `Derive` to choose to relax this restriction. This is necessary for #8875, #8876, and #8877.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_move_clone_in_default_to_types branch from b1e3cb1 to 3407d47 Compare February 4, 2025 02:53
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 3c771fc to 6628e1d Compare February 4, 2025 02:54
Base automatically changed from 02-03-refactor_ast_move_clone_in_default_to_types to main February 4, 2025 03:48
@graphite-app graphite-app bot merged commit 6628e1d into main Feb 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_move_estree_skip_to_types branch February 4, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant