refactor(ast): #[content_eq(skip)] attr#8875
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Merged
Conversation
This was referenced Feb 3, 2025
Member
Author
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8875 will not alter performanceComparing Summary
|
c4e297d to
7a74484
Compare
0d0fa2e to
480a1e4
Compare
This was referenced Feb 3, 2025
7a74484 to
dd71d68
Compare
480a1e4 to
65f004a
Compare
Contributor
Merge activity
|
Introduce custom attribute `#[content_eq(skip)]` to guide code generation for `ContentEq` trait. Instead of a hard-coded list of types to skip in codegen, use this attribute on types to control the behavior.
dd71d68 to
f40f494
Compare
65f004a to
caa651c
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Generate implementations of `ContentEq` trait on literal types instead of writing them manually, using the `#[content_eq(skip)]` attribute introduced in #8875 to skip fields which shouldn't be included.
Base automatically changed from
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
to
main
February 4, 2025 03:43
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introduce custom attribute
#[content_eq(skip)]to guide code generation forContentEqtrait. Instead of a hard-coded list of types to skip in codegen, use this attribute on types to control the behavior.