refactor(ast): override TS type defs with #[estree(custom_ts_def)] attribute on type#8897
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Conversation
This was referenced Feb 4, 2025
Member
Author
CodSpeed Performance ReportMerging #8897 will not alter performanceComparing Summary
|
ef44aba to
d4eb7a7
Compare
This was referenced Feb 4, 2025
6b8e955 to
7c8743e
Compare
d4eb7a7 to
5046b09
Compare
Contributor
Merge activity
|
…attribute on type (#8897) Instead of an extra file `custom_types.d.ts` containing type definitions for a few types where we need to override the TS type def, include those TS definitions in `#[estree(custom_ts_def = "...")]` attribute on the Rust types.
7c8743e to
6185619
Compare
5046b09 to
223eb8d
Compare
Base automatically changed from
02-04-refactor_ast_tools_improve_correctness_and_performance_of_idents
to
main
February 4, 2025 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Instead of an extra file
custom_types.d.tscontaining type definitions for a few types where we need to override the TS type def, include those TS definitions in#[estree(custom_ts_def = "...")]attribute on the Rust types.