fix(codegen): print type annotation on `CatchParameter` by camc314 · Pull Request #19790 · oxc-project/oxc

camc314 · 2026-02-26T19:17:15Z

No description provided.

camc314 · 2026-02-26T19:17:32Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR fixes a code generation bug where TypeScript type annotations on catch parameters were not being printed. Previously, the codegen would omit the type annotation when generating code for catch clauses with typed parameters.

Changes:

Added logic to print type annotations on catch parameters following the established pattern used elsewhere in the codebase
Added a test case to verify that catch parameters with type annotations are correctly preserved

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`crates/oxc_codegen/src/gen.rs`	Added type annotation printing logic in `CatchClause::r#gen` method
`crates/oxc_codegen/tests/integration/ts.rs`	Added test case verifying catch parameter type annotation is preserved

codspeed-hq · 2026-02-26T19:23:31Z

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-26-fix_codegen_print_type_annotation_on_catchparameter_ (bb62b6e) with c/02-26-fix_codegen_wrap_tsconditionaltype_in_parens_when_necessary (38a5df4)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on c/02-26-fix_codegen_wrap_tsconditionaltype_in_parens_when_necessary (3d41238) during the generation of this report, so c0c4cb5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Dunqing · 2026-02-27T08:27:36Z

Merge activity

Feb 27, 8:27 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 27, 8:27 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Feb 27, 8:39 AM UTC: Merged by the Graphite merge queue.

### 🚀 Features - 733d6dc parser: Report error on `infer` outside conditional type (#19879) (camc314) - c2a42f6 allocator: Add `Vec::into_bump_slice_mut` (#19895) (overlookmotel) - ee4982b parser: Add `VARIANTS` const to `Kind` via `fieldless_enum!` macro (#19877) (overlookmotel) - b3dceae data_structures: Add `fieldless_enum!` macro (#19876) (overlookmotel) - 12b841e parser: Make all `Kind::is_*` methods `const` (#19874) (overlookmotel) - 25c2e25 estree/tokens: Add function to update tokens in place (#19856) (overlookmotel) - f78e6df parser: Add `mutate_tokens` Cargo feature (#19853) (overlookmotel) - 5036bb6 parser: Report error on `for await` in static blocks (#19844) (camc314) - 42bd431 parser: Report error for missing initializer in using decl (#19824) (camc314) - a2f58e5 parser: Report error for `implements` clause in non-ts files (#19820) (Cameron) - b25228a estree: Add `IS_COMPACT` const to `Formatter` trait (#19787) (overlookmotel) - e2a1b79 estree: Expose buffer and formatter of serializers (#19773) (overlookmotel) - 4699498 data_structures: Add `CodeBuffer::print_strs_array` (#19760) (overlookmotel) - 233f947 estree: `oxc_estree` crate export config and formatter types (#19724) (overlookmotel) - 5937a32 semantic: Introduce `symbol_declarations` method (#19609) (camc314) - ea6b796 parser: Add `LexerConfig::TOKENS_METHOD_IS_STATIC` const (#19683) (overlookmotel) - 655c38f semantic: Add "did you mean?" suggestions to undefined name errors (#19102) (copilot-swe-agent) - 9e11dc6 parser,estree,coverage: Collect tokens in parser and convert to ESTree format (#19497) (camc314) - c4a3677 parser: Report error for initializer in ambient context (#19187) (camc314) ### 🐛 Bug Fixes - abc7e19 codegen: Improve parenthesised checks when printing types (#19880) (camc314) - 017de5d parser: Update error code for type annotation in `for...in` statement (#19882) (camc314) - 7682e5a linter/plugins: Decode escapes in identifier tokens (#19838) (overlookmotel) - 06767ed estree/tokens: Convert `this` tokens in `TSTypeName` (#19815) (overlookmotel) - ef798af parser: Use TS8037 for satisfies expression in JS files diagnostic (#19819) (camc314) - 98ea5c5 parser: Use TS8016 for type assertions in JS files diagnostic (#19818) (camc314) - 1710f56 codegen: Remove double indentation for enum inside namespace (#19775) (Dunqing) - 9e4995c codegen: Print type annotation on `CatchParameter` (#19790) (camc314) - 297b2bb codegen: Wrap `TSConditionalType` in parens when necessary (#19788) (camc314) - cec7878 codegen: Print `definite` property on AccessorProperty (#19786) (camc314) - 6f395cf codegen: Print `definite` property on PropertyDefinition (#19785) (camc314) - b749373 codegen: Correctly parenthesise TSArrayType (#19784) (camc314) - 876dc1b codegen: Print object property `this` param (#19783) (camc314) - 93bb861 formatter: Trim trailing whitespace before breaking line (#19740) (leaysgur) - ed17bbf codegen: Print `override` keyword for method and property definitions (#19753) (Dunqing) - 6a59a76 parser: Improve error recovery for private identifiers in property names (#19710) (Boshen) - 3b96f41 codegen: Print comments in JSX expression containers and spread attributes (#19701) (Boshen) - f5694ce estree/tokens: Reverse field order of `regex` object in tokens (#19679) (overlookmotel) - b2b7a55 estree/tokens: Generate tokens for files with BOM (#19535) (overlookmotel) - 50a7514 estree: Fix tokens for JSX (#19524) (overlookmotel) - a35063e minifier: Preserve side effects for meta property url reads (#19668) (Boshen) - 8ad3430 semantic/jsdoc: Handle even-numbered backtick sequences in JSDoc parsing (#19664) (Boshen) ### ⚡ Performance - 05ccf9f linter/plugins: Transfer tokens via raw transfer (#19893) (overlookmotel) - c1bfdcf estree/tokens: Preallocate sufficient space for tokens JSON (#19851) (overlookmotel) - 4b0611a estree/tokens: Introduce `ESTreeTokenConfig` trait (#19842) (overlookmotel) - 81bab90 estree/tokens: Do not JSON-encode keyword, punctuator, etc tokens (#19814) (overlookmotel) - 6260ddd estree/tokens: Do not JSON-encode `this` identifiers (#19813) (overlookmotel) - b378f4a estree/tokens: Do not JSON-encode JSX identifiers (#19812) (overlookmotel) - 5016d92 estree/tokens: Handle regex tokens separately (#19796) (overlookmotel) - 780a68e estree/tokens: Use strings from AST for identifier tokens (#19744) (overlookmotel) - dc9c2e3 estree: Use `CodeBuffer::print_strs_array` to reduce bounds checks (#19766) (overlookmotel) - 845da35 estree: Use `CodeBuffer::print_indent` (#19727) (overlookmotel) - ec88f6a estree/tokens: Serialize tokens while visiting AST (#19726) (overlookmotel) - bc6507f estree/tokens: Serialize with `ESTree` not `serde` (#19725) (overlookmotel) - ec24859 estree/tokens: Do not branch on presence of override twice (#19721) (overlookmotel) - dac14be estree/tokens: Replace hash map with `Vec` (#19718) (overlookmotel) - b9d2443 estree/tokens: Replace multiple hash sets into a single hash map (#19716) (overlookmotel) - 7233548 parser: Remove branches from `finish_next_inner` (#19695) (overlookmotel) - b5d9845 parser: Remove const generic param from `finish_next_inner` (#19684) (overlookmotel) - 8940f66 estree/tokens: Serialize tokens to compact JSON (#19572) (overlookmotel) - 136e39b parser/tokens: Pre-allocate capacity for tokens (#19543) (overlookmotel) - 6a6513c linter/plugins: Use Oxc tokens in plugins (#19498) (camc314) - b3b2d30 parser: Introduce `ParserConfig` (#19637) (overlookmotel) ### 📚 Documentation - b2b7a64 estree/tokens: Correct comment (#19873) (overlookmotel) - 0399311 estree/tokens: Improve comments (#19836) (overlookmotel) - 1b392de minifier: Add `Function.prototype.toString` assumption (#19758) (sapphi-red) - 75c9cd8 parser: Improve doc comments for `ParserConfig` and `LexerConfig` (#19682) (overlookmotel) - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

camc314 mentioned this pull request Feb 26, 2026

fix(codegen): wrap TSConditionalType in parens when necessary #19788

Merged

camc314 marked this pull request as ready for review February 26, 2026 19:17

Copilot AI review requested due to automatic review settings February 26, 2026 19:17

This was referenced Feb 26, 2026

fix(codegen): print object property this param #19783

Merged

fix(codegen): correctly parenthesise TSArrayType #19784

Merged

fix(codegen): print definite property on PropertyDefinition #19785

Merged

camc314 mentioned this pull request Feb 26, 2026

fix(codegen): print definite property on AccessorProperty #19786

Merged

github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Feb 26, 2026

Copilot started reviewing on behalf of camc314 February 26, 2026 19:18 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Dunqing approved these changes Feb 27, 2026

View reviewed changes

Dunqing added the 0-merge Merge with Graphite Merge Queue label Feb 27, 2026

fix(codegen): print type annotation on CatchParameter (#19790)

9e4995c

graphite-app bot force-pushed the c/02-26-fix_codegen_wrap_tsconditionaltype_in_parens_when_necessary branch from 3d41238 to 297b2bb Compare February 27, 2026 08:30

graphite-app bot force-pushed the c/02-26-fix_codegen_print_type_annotation_on_catchparameter_ branch from bb62b6e to 9e4995c Compare February 27, 2026 08:31

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 27, 2026

Base automatically changed from c/02-26-fix_codegen_wrap_tsconditionaltype_in_parens_when_necessary to main February 27, 2026 08:38

graphite-app bot merged commit 9e4995c into main Feb 27, 2026
22 checks passed

graphite-app bot deleted the c/02-26-fix_codegen_print_type_annotation_on_catchparameter_ branch February 27, 2026 08:39

Boshen mentioned this pull request Mar 2, 2026

release(crates): oxc v0.116.0 #19911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(codegen): print type annotation on `CatchParameter`#19790

fix(codegen): print type annotation on `CatchParameter`#19790
graphite-app[bot] merged 1 commit intomainfrom
c/02-26-fix_codegen_print_type_annotation_on_catchparameter_

camc314 commented Feb 26, 2026

Uh oh!

camc314 commented Feb 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Feb 26, 2026

Uh oh!

Dunqing commented Feb 27, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Feb 26, 2026

Uh oh!

camc314 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq bot commented Feb 26, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Dunqing commented Feb 27, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Feb 26, 2026 •

edited

Loading

Dunqing commented Feb 27, 2026 •

edited by graphite-app bot

Loading