fix(minifier): preserve side effects for meta property url reads

[Boshen]

Summary

• remove the MetaProperty.url side-effect-free special-case from property read analysis
• treat import.meta.url reads as side-effectful in side-effect tests
• add regression coverage for both import.meta.url and new.target.url getter side effects

Closes #19466
Closes #19467

Testing

• just fmt
• cargo test -p oxc_minifier test_property_access
• cargo test -p oxc_minifier test_esm_minification_edge_cases
• cargo test -p oxc_minifier test_meta_property_url_getter_side_effects

AI Disclosure

This PR was prepared with AI assistance (OpenAI Codex) and reviewed by the contributor.

[Copilot]

Pull request overview

This PR fixes two minifier bugs where property access side effects on meta properties were incorrectly eliminated. The issues occurred when custom getters with side effects were defined on import.meta.url (issue #19466) and new.target.url (issue #19467). The minifier was treating these property accesses as side-effect-free and removing them during optimization.

Changes:

• Removed the special-case optimization that treated url property reads on MetaProperty expressions as side-effect-free
• Updated side effect tests to correctly identify import.meta.url and new.target.url as having potential side effects
• Added regression test coverage demonstrating that custom getters on these properties are now preserved

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_ecmascript/src/side_effects/expressions.rs	Removed the incorrect special case that treated url property access on MetaProperty as side-effect-free
crates/oxc_minifier/tests/ecmascript/may_have_side_effects.rs	Updated test expectations for import.meta.url and new.target.url from false to true to reflect correct side effect analysis
crates/oxc_minifier/tests/peephole/obscure_edge_cases.rs	Changed import.meta.url test to preserve the expression and added comprehensive regression tests for both meta property URL getter side effects

[Boshen]

Merge activity

• Feb 24, 8:27 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 24, 8:30 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Feb 24, 8:37 AM UTC: Merged by the Graphite merge queue.

[codspeed-hq]

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing fix/minifier-meta-url-side-effects (d2e988b) with main (42b9c03)}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩