Handle audit log path in /var/log/origin #10717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roles/cluster_monitoring: minor wording improvement
Use clusterid attribute to filter servers in dynamic inventory
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
This migration task was required for 3.9 -> 3.10 upgrade, but its no longer required
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
This probe script is available in new containers only and thus the fallback if statement. In addition, we provide an env var that allows the user to disable the check for gluster-blockd. Signed-off-by: John Mulligan <[email protected]>
glusterfs: add probe script for liveness and readiness checks
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
…e wait for global PR in openshift/origin to merge)
Remove unused registry migration task
prelim/partial update to jenkins imagestream to enable tests (while w…
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Adding openshift_kubelet_name_override as a stand-in for various places we will need to account for possible hostname overrides.
The current code calls umount /var/lib/docker/containers, then immediately uses /var/lib/docker/containers for an selinux operation, then attempts to remove the directory. The removal will sometimes fail with a "filesystem busy" error, I think because doing the selinux operation after unmounting somehow causes it to be busy. Doing the unmount after all of the operations, and just before doing the removal, seems to fix this condition.
unmount just before removing
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
This would ensure sync DS annotation check passes on installs with slow nodes (or a large number of nodes)
…hostname Fail on openshift_hostname defined; add openshift_kubelet_name_override
This allows us to optionally use override as we see fit.
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
'pod_vif=nested-vlan' label was missing for master nodes in openshift_node_groups section, both in documentation file and in OSEv3 sample inventory file.
Increase number of retries in sync DS
Add missing option in Openstack documentation and sample file.
Fix etcd scaleup on standalone hosts
openshift-ci-robot
added
the
approved
added 2 commits
December 3, 2018 17:49
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Contributor
|
/retest |
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Contributor
|
/retest |
added 9 commits
December 6, 2018 09:42
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
Member
Author
|
/test e2e-aws |
Created by command: /usr/bin/tito tag --debug --accept-auto-changelog --keep-version --debug
|
New changes are detected. LGTM label has been removed. |
|
@rsevilla87: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-rebase
|
@rsevilla87: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is intended to make the installer able to handle OpenShift audit log paths different from (/etc/origin/master, /var/lib/origin, /etc/origin/cloudprovider), which in most of cases are not appropriate since those directories are not usually used as log store.
The code included create a new directory /var/log/origin if auditFilePath is defined within this directory, and adds it as a hostPath in the apiserver static pod definition. custom module master_check_paths_in_config has been also properly tuned to allow this directories to be defined in the master-config.yaml
If accepted, this change should be properly documented.
More info: #10715