Skip to content

Conversation

@eurijon
Copy link
Contributor

@eurijon eurijon commented Oct 9, 2018

'pod_vif=nested-vlan' label was missing for master nodes in
openshift_node_groups section, both in documentation file
and in OSEv3 sample inventory file.

'pod_vif=nested-vlan' label was missing for master nodes in
openshift_node_groups section, both in documentation file
and in OSEv3 sample inventory file.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2018
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2018
@papr-bot
Copy link

papr-bot commented Oct 9, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 9, 2018

/ok-to-test
/lgtm
/cherrypick release-3.11

@openshift-cherrypick-robot

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

Details

In response to this:

/ok-to-test
/lgtm
/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2018
@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 9, 2018

/cherrypick release-3.10

@openshift-cherrypick-robot

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eurijon, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@openshift-merge-robot openshift-merge-robot merged commit ff11316 into openshift:master Oct 9, 2018
@openshift-cherrypick-robot

@vrutkovs: new pull request created: #10366

Details

In response to this:

/ok-to-test
/lgtm
/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #10367

Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants