Skip to content

prelim/partial update to jenkins imagestream to enable tests (while w… #10323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 5, 2018
Merged

prelim/partial update to jenkins imagestream to enable tests (while w… #10323

openshift-merge-robot merged 1 commit into from
Oct 5, 2018

Conversation

@gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Oct 4, 2018

…e wait for global PR in openshift/origin to merge)

@bparees per discussion on IRC

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2018
@bparees
Copy link
Contributor

bparees commented Oct 4, 2018

@gabemontero please change the rhel one too, so at least those two are in sync.

@gabemontero
Copy link
Contributor Author

gabemontero commented Oct 4, 2018

@bparees I do not believe there are v4.0 images yet for rhel .... changing to that will break things

@bparees
Copy link
Contributor

bparees commented Oct 4, 2018

@bparees I do not believe there are v4.0 images yet for rhel .... changing to that will break things

there are never v4.0 images for rhel until we GA. QE knows how to modify the imagestream as needed.

@gabemontero
prelim/partial update to jenkins imagestream to enable tests (while w…
a6eb4eb 
…e wait for global PR in openshift/origin to merge)
@gabemontero
Copy link
Contributor Author

gabemontero commented Oct 4, 2018

rhel update

@bparees
Copy link
Contributor

bparees commented Oct 4, 2018

/lgtm

@sdodson fyi

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2018
@gabemontero
Copy link
Contributor Author

gabemontero commented Oct 4, 2018

the travis failure was a hiccup downloading python

vrutkovs
vrutkovs approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@openshift-merge-robot openshift-merge-robot merged commit 6c52939 into openshift:master Oct 5, 2018
@gabemontero gabemontero deleted the bump-streams-to-4.0 branch October 8, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@sdodson sdodson Awaiting requested review from sdodson

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabemontero @bparees @openshift-ci-robot @vrutkovs @openshift-merge-robot