-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improve advanced audit documentation #13351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @rsevilla87. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@soltysh, will you PTAL? |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0ef243e to
c038b97
Compare
|
/ok-to-test |
|
@kalexand-rh just for 3.11, right? Not master? |
|
@vikram-redhat, no, it should go in master, and I wouldn't be surprised if it's relevant in more than 3.11. The audit log information is old, and I can't remember when the master API switched to static pods. (This PR could also use a text edit and squash.) @xingxingxia, do you know how far back this change is valid? |
|
@rsevilla87 - could you submit this PR against the master and squash the commits? |
0426095 to
d469d23
Compare
It should be also cherry-picked to 3.10 |
|
@kalexand-rh sorry for delay due to holidays and later other work. Valid since version >= 3.10 using static pods, 3.10 began to report similar https://bugzilla.redhat.com/show_bug.cgi?id=1565555, https://bugzilla.redhat.com/show_bug.cgi?id=1615798 |
|
Thank you for checking @xingxingxia! |
|
Closing in favor of #13690 |
Make audit configuration match with the real behavior of openshift-ansible:
openshift/openshift-ansible#10856