Skip to content

Conversation

@rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Jan 17, 2019

Make audit configuration match with the real behavior of openshift-ansible:

openshift/openshift-ansible#10856

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2019
@openshift-ci-robot
Copy link

Hi @rsevilla87. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rsevilla87 rsevilla87 changed the title Improve advanced audit configuration Improve advanced audit documentation Jan 17, 2019
@kalexand-rh
Copy link
Contributor

@soltysh, will you PTAL?

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kalexand-rh kalexand-rh force-pushed the enterprise-3.11 branch 2 times, most recently from 0ef243e to c038b97 Compare January 24, 2019 16:40
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 1, 2019
@vikram-redhat
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2019
@vikram-redhat
Copy link
Contributor

@kalexand-rh just for 3.11, right? Not master?

@kalexand-rh
Copy link
Contributor

@vikram-redhat, no, it should go in master, and I wouldn't be surprised if it's relevant in more than 3.11. The audit log information is old, and I can't remember when the master API switched to static pods. (This PR could also use a text edit and squash.)

@xingxingxia, do you know how far back this change is valid?

@vikram-redhat
Copy link
Contributor

@rsevilla87 - could you submit this PR against the master and squash the commits?

@rsevilla87
Copy link
Member Author

@kalexand-rh just for 3.11, right? Not master?

It should be also cherry-picked to 3.10

@xingxingxia
Copy link
Contributor

@kalexand-rh sorry for delay due to holidays and later other work. Valid since version >= 3.10 using static pods, 3.10 began to report similar https://bugzilla.redhat.com/show_bug.cgi?id=1565555, https://bugzilla.redhat.com/show_bug.cgi?id=1615798

@kalexand-rh
Copy link
Contributor

Thank you for checking @xingxingxia!

@kalexand-rh
Copy link
Contributor

Closing in favor of #13690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants