Skip to content

Fix etcd scaleup on standalone hosts #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 9, 2018
Merged

Fix etcd scaleup on standalone hosts #10257

openshift-merge-robot merged 1 commit into from
Oct 9, 2018

Conversation

@mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Sep 27, 2018

  • Updated detection of running on standalone or as static pods
  • Set value of etcdctlv2 for all hosts to ensure proper usage
  • Use proper etcdctlv2 for adding new etcd members

@mtnbikenc
Fix etcd scaleup on standalone hosts
876c558 
* Updated detection of running on standalone or as static pods
* Set value of etcdctlv2 for all hosts to ensure proper usage
* Use proper etcdctlv2 for adding new etcd members
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 27, 2018
@mtnbikenc mtnbikenc mentioned this pull request Sep 27, 2018
Merged
michaelgugino
michaelgugino approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdodson sdodson added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
sdodson
sdodson approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@sdodson sdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,mtnbikenc,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 8, 2018

/refresh

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 8, 2018

/skip

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 9, 2018

/retest

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a880ade into openshift:master Oct 9, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2018

@mtnbikenc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-major-upgrade-master 876c558 link /test e2e-gcp-major-upgrade-master
ci/prow/e2e-gcp 876c558 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtnbikenc mtnbikenc deleted the fix-etcd-scaleup-standalone branch November 5, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdodson sdodson sdodson approved these changes

+1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mtnbikenc @openshift-ci-robot @vrutkovs @openshift-bot @sdodson @michaelgugino @openshift-merge-robot