-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Handle audit log path in /var/log/origin #10856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle audit log path in /var/log/origin #10856
Conversation
|
Hi @rsevilla87. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
|
/lgtm |
|
@sdodson: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rsevilla87, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sdodson: new pull request created: #10863 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit is intended to make the installer able to handle OpenShift audit log paths different from (/etc/origin/master, /var/lib/origin, /etc/origin/cloudprovider), which in most of cases are not appropriate since those directories are not usually used as log store.
The code included create a new directory /var/log/origin if auditFilePath is defined within this directory, and adds it as a hostPath in the apiserver static pod definition. custom module master_check_paths_in_config has been also properly tuned to allow this directories to be defined in the master-config.yaml
If accepted, this change should be properly documented.
More info: #10717