Skip to content

Conversation

@rsevilla87
Copy link
Member

This commit is intended to make the installer able to handle OpenShift log paths different from (/etc/origin/master, /var/lib/origin, /etc/origin/cloudprovider), which in most of cases are not appropiate since those directories are not usually used as log store.

The code included create new directory (if applies) and adds it as a hostPath in the apiserver static pod definition. The code of the custom module master_check_paths_in_config has been also properly tuned to allow this directories to be defined in the master-config.yaml

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rsevilla87
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdodson

If they are not already assigned, you can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2018
@openshift-ci-robot
Copy link

Hi @rsevilla87. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@vrutkovs
Copy link
Contributor

vrutkovs commented Nov 18, 2018

Hostmounting arbitrary folders is a bad and dangerous idea, what's wrong with using /var/lib/origin?

@rsevilla87
Copy link
Member Author

rsevilla87 commented Nov 18, 2018

@vrutkovs In most cases /var/log is an independent mount point and /var/lib/origin has not been sized to store logs.

@vrutkovs
Copy link
Contributor

I'm still not sure if this is a good idea, but in any case master branch would soon be significantly reworked for 4.0 install.

Please open a new PR for release-3.11 branch instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants