unmount just before removing #10337
unmount just before removing #10337
Conversation
The current code calls umount /var/lib/docker/containers, then immediately uses /var/lib/docker/containers for an selinux operation, then attempts to remove the directory. The removal will sometimes fail with a "filesystem busy" error, I think because doing the selinux operation after unmounting somehow causes it to be busy. Doing the unmount after all of the operations, and just before doing the removal, seems to fix this condition.
openshift-ci-robot
added
the
size/S
|
This is a big problem doing crio testing - surprised no one else has run into this. |
|
can't tell if problem with PR or flake . . . |
|
/test e2e-gcp |
|
/cherrypick release-3.11 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, richm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
Looks reasonable to me. |
|
/cherrypick release-3.10 |
|
@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@michaelgugino: new pull request created: #10344 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@michaelgugino: new pull request created: #10345 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
The current code calls umount /var/lib/docker/containers, then
immediately uses /var/lib/docker/containers for an selinux
operation, then attempts to remove the directory. The removal
will sometimes fail with a "filesystem busy" error, I think because
doing the selinux operation after unmounting somehow causes it
to be busy. Doing the unmount after all of the operations, and
just before doing the removal, seems to fix this condition.