Skip to content

Increase number of retries in sync DS #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 9, 2018
Merged

Increase number of retries in sync DS #10353

openshift-merge-robot merged 1 commit into from
Oct 9, 2018

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Oct 8, 2018

This would ensure sync DS annotation check passes on installs with slow
nodes (or a large number of nodes)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1636914

Increase number of retries in sync DS
7f02e0d 
This would ensure sync DS annotation check passes on installs with slow 
nodes (or a large number of nodes)
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2018
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 8, 2018

/cherrypick release-3.11

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 8, 2018

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@sdodson
Copy link
Member

sdodson commented Oct 8, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Oct 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

openshift-bot commented Oct 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ead311e into openshift:master Oct 9, 2018
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2018
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 9, 2018

@vrutkovs: new pull request created: #10363

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 12, 2018

/cherrypick release-3.10

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 12, 2018

@vrutkovs: #10353 failed to apply on top of branch "release-3.10":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	roles/openshift_manage_node/tasks/config.yml
M	roles/openshift_node_group/tasks/sync.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_node_group/tasks/sync.yml
CONFLICT (content): Merge conflict in roles/openshift_node_group/tasks/sync.yml
Auto-merging roles/openshift_manage_node/tasks/config.yml
Patch failed at 0001 Increase number of retries in sync DS
Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request Oct 12, 2018
Merged
@vrutkovs vrutkovs deleted the sync-ds-increase-retries branch January 5, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vrutkovs @openshift-cherrypick-robot @sdodson @openshift-ci-robot @openshift-bot @openshift-merge-robot