Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 2, 2024

Adding temporary fallbacks while the migration is in progress. In this pass, covering all components that have already migrated to golang 1.22 but still have .rhel7 or .rhel8 in their name

Upstream PRs raised:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Validating 21 file(s)...
Validating images/coredns.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/coredns.yml
Returned error: Additional properties are not allowed ('dockerfile_fallback' was unexpected)

@ashwindasr ashwindasr force-pushed the go-1.22-dockerfile-fallbacks branch from c579d8e to 34882e1 Compare July 2, 2024 17:43
@openshift-bot
Copy link

Validating 23 file(s)...
Validating images/coredns.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/coredns.yml
Returned error: Additional properties are not allowed ('dockerfile_fallback' was unexpected)

@ashwindasr
Copy link
Contributor Author

Validator PR merged, should be good once we have a new art-tools build openshift-eng/art-tools#734

@ashwindasr ashwindasr force-pushed the go-1.22-dockerfile-fallbacks branch from 34882e1 to ff68ba9 Compare July 2, 2024 17:50
@openshift-bot
Copy link

Validating 23 file(s)...
Validating images/coredns.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/coredns.yml
Returned error: Additional properties are not allowed ('dockerfile_fallback' was unexpected)

@ashwindasr ashwindasr force-pushed the go-1.22-dockerfile-fallbacks branch from ff68ba9 to 32a096d Compare July 2, 2024 17:52
@openshift-bot
Copy link

Validating 23 file(s)...
Validating images/coredns.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/coredns.yml
Returned error: Additional properties are not allowed ('dockerfile_fallback' was unexpected)

@ashwindasr ashwindasr merged commit b02b932 into openshift-eng:openshift-4.17 Jul 2, 2024
@ashwindasr ashwindasr deleted the go-1.22-dockerfile-fallbacks branch July 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants