-
Notifications
You must be signed in to change notification settings - Fork 114
NO-JIRA: Rename Dockerfile #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Rename Dockerfile #955
Conversation
d56849d to
c3a3961
Compare
c3a3961 to
a7cd7f7
Compare
|
@ashwindasr: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Needs to merge with an ocp-build-data PR |
|
Hi @ashwindasr I am fine with the changes do you prefer to merge the release repo first? |
|
Thanks @SchSeba, yes lets get the release PR in first. Also if you can lgtm, approve to this PR as well, I can shepherd the PRs to merge |
|
also the release PR openshift/release#54079 seems to be missing a approved label? |
|
Dependency PR is merged /hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
Change the SriovNetwork Vlan max value validation
Refactor name to
Dockerfile.ocpas a better, version independent, alternative since contents are actually rhel9.CI: openshift/release#54079 (probably needs to merge first)
Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.