Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54079 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

@ashwindasr ashwindasr force-pushed the rename-dockerfile branch from c3a3961 to a7cd7f7 Compare July 5, 2024 18:29
@ashwindasr ashwindasr changed the title Rename Dockerfile NO-JIRA: Rename Dockerfile Jul 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request explicitly references no jira issue.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54079 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Contributor Author

/hold

Needs to merge with an ocp-build-data PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@SchSeba
Copy link
Contributor

SchSeba commented Jul 17, 2024

Hi @ashwindasr I am fine with the changes do you prefer to merge the release repo first?

@ashwindasr
Copy link
Contributor Author

ashwindasr commented Jul 17, 2024

Thanks @SchSeba, yes lets get the release PR in first. Also if you can lgtm, approve to this PR as well, I can shepherd the PRs to merge

@ashwindasr
Copy link
Contributor Author

also the release PR openshift/release#54079 seems to be missing a approved label?

@zeeke
Copy link
Contributor

zeeke commented Sep 2, 2024

Dependency PR is merged

/hold cancel
/approve
/lgtm
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a702ebf into openshift:master Sep 2, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook
This PR has been included in build sriov-network-webhook-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator
This PR has been included in build sriov-network-operator-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon
This PR has been included in build sriov-network-config-daemon-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9.
All builds following this will include this PR.

SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Nov 6, 2025
Change the SriovNetwork Vlan max value validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants