-
Notifications
You must be signed in to change notification settings - Fork 12
OCPBUGS-36455: Rename Dockerfile to Dockerfile.ocp #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-36455: Rename Dockerfile to Dockerfile.ocp #77
Conversation
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36455, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The release PR has to merge first, for tests to pass |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
f15dd6d to
5bbf33e
Compare
|
Updated commit description, since verify-commits job was failing |
|
@ashwindasr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@ashwindasr: Jira Issue OCPBUGS-36455: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36455 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build csi-attacher-container-v4.17.0-202407052343.p0.gaad6c31.assembly.stream.el9 for distgit csi-attacher. |
Refactor name to
Dockerfile.ocpas a better, version independent, alternative since contents are actually rhel9.CI: openshift/release#53934
Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.