-
Notifications
You must be signed in to change notification settings - Fork 88
OCPBUGS-36521: Rename Dockerfile #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-36521: Rename Dockerfile #407
Conversation
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@xiuwang: This pull request references Jira Issue OCPBUGS-36521, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
|
/retest |
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to do this in three steps:
- Copy
Dockerfile.rhel7toDockerfile.ocpin this PR - Once this PR lands, you can merge openshift/release#53995
- Finally, submit a follow-up PR that removes
Dockerfile.rhel7.
|
@adambkaplan @gabemontero In the other components that we had the same issue, we merged the release PR first and then ran /retest here which made tests pass. Not sure if we can try this here as well, unless I'm missing something. This PR description lists the other upstream PRs that ART has raised. |
|
/hold Needs to merge with an ocp-build-data PR |
|
release PR merged. |
|
@ashwindasr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, flavianmissi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
@ashwindasr: Jira Issue OCPBUGS-36521: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36521 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-registry |
Refactor name to
Dockerfile.ocpas a better, version independent, alternative since contents are actually rhel9.CI: openshift/release#53995 (probably needs to merge first)
Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.