Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 3, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53995 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

@openshift-ci openshift-ci bot requested review from dmage and gabemontero July 3, 2024 18:03
@ashwindasr ashwindasr changed the title Rename Dockerfile OCPBUGS-36521: Rename Dockerfile Jul 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 3, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53995

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiuwang July 3, 2024 18:05
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53995 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiuwang
Copy link

xiuwang commented Jul 4, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@xiuwang: This pull request references Jira Issue OCPBUGS-36521, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wewang58

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wewang58 July 4, 2024 01:49
@wewang58
Copy link

wewang58 commented Jul 4, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 4, 2024
@wewang58
Copy link

wewang58 commented Jul 4, 2024

/retest

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to do this in three steps:

  1. Copy Dockerfile.rhel7 to Dockerfile.ocp in this PR
  2. Once this PR lands, you can merge openshift/release#53995
  3. Finally, submit a follow-up PR that removes Dockerfile.rhel7.

@ashwindasr
Copy link
Contributor Author

ashwindasr commented Jul 9, 2024

@adambkaplan @gabemontero In the other components that we had the same issue, we merged the release PR first and then ran /retest here which made tests pass. Not sure if we can try this here as well, unless I'm missing something.

This PR description lists the other upstream PRs that ART has raised.

@ashwindasr
Copy link
Contributor Author

/hold

Needs to merge with an ocp-build-data PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@flavianmissi
Copy link
Member

release PR merged.
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@ashwindasr
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 134be6f into openshift:master Jul 22, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: Jira Issue OCPBUGS-36521: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36521 has been moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53995 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr ashwindasr deleted the rename-dockerfile branch July 22, 2024 15:22
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-registry
This PR has been included in build openshift-enterprise-registry-container-v4.17.0-202407221718.p0.g134be6f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants