Skip to content

Conversation

@ashwindasr
Copy link

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53996

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

@openshift-ci openshift-ci bot requested review from 2uasimojo and lleshchi July 3, 2024 18:09
@ashwindasr ashwindasr changed the title Rename Dockerfile OCPBUGS-36522: Rename Dockerfile Jul 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 3, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36522, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53996

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianping-shu
Copy link

/retest

@jstuever
Copy link

Will try testing again after openshift/release#53996 merges.

@jstuever
Copy link

/assign

@ashwindasr
Copy link
Author

/retest

@ashwindasr ashwindasr changed the title OCPBUGS-36522: Rename Dockerfile NO-JIRA: Rename Dockerfile Jul 10, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 10, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request explicitly references no jira issue.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53996

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr ashwindasr changed the title NO-JIRA: Rename Dockerfile OCPBUGS-36522: Rename Dockerfile Jul 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 10, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36522, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53996

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jstuever
Copy link

/override ci/prow/security
A Jira bug exists to resolve this separately.

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2024

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

Details

In response to this:

/override ci/prow/security
A Jira bug exists to resolve this separately.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b91c75b into openshift:master Jul 11, 2024
@openshift-ci-robot
Copy link

@ashwindasr: Jira Issue OCPBUGS-36522: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36522 has been moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53996

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-pod-identity-webhook-container-v4.17.0-202407112212.p0.gb91c75b.assembly.stream.el9 for distgit ose-aws-pod-identity-webhook.
All builds following this will include this PR.

dlom pushed a commit to dlom/aws-pod-identity-webhook that referenced this pull request Sep 30, 2024
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.9.0 to 0.17.0.
- [Commits](golang/net@v0.9.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants