Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 16, 2024

For components that have migrated, remove fallbacks (ref #5039), else keep back the original name. So that we can solve issues with the sync-ci pipeline

@ashwindasr
Copy link
Contributor Author

/cherry-pick openshift-4.18

@openshift-cherrypick-robot

@ashwindasr: once the present PR merges, I will cherry-pick it on top of openshift-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Validating 23 file(s)...
Validating images/coredns.yml...
✅ Validated images/coredns.yml
Validating images/csi-attacher.yml...
✅ Validated images/csi-attacher.yml
Validating images/csi-livenessprobe.yml...
✅ Validated images/csi-livenessprobe.yml
Validating images/openshift-enterprise-ansible-operator.yml...
✅ Validated images/openshift-enterprise-ansible-operator.yml
Validating images/openshift-enterprise-cluster-capacity.yml...
✅ Validated images/openshift-enterprise-cluster-capacity.yml
Validating images/openshift-enterprise-console-operator.yml...
✅ Validated images/openshift-enterprise-console-operator.yml
Validating images/openshift-enterprise-registry.yml...
✅ Validated images/openshift-enterprise-registry.yml
Validating images/ose-aws-pod-identity-webhook.yml...
✅ Validated images/ose-aws-pod-identity-webhook.yml
Validating images/ose-cluster-config-api.yml...
✅ Validated images/ose-cluster-config-api.yml
Validating images/ose-cluster-config-operator.yml...
✅ Validated images/ose-cluster-config-operator.yml
Validating images/ose-cluster-csi-snapshot-controller-operator.yml...
✅ Validated images/ose-cluster-csi-snapshot-controller-operator.yml
Validating images/ose-cluster-kube-apiserver-operator.yml...
✅ Validated images/ose-cluster-kube-apiserver-operator.yml
Validating images/ose-cluster-kube-controller-manager-operator.yml...
✅ Validated images/ose-cluster-kube-controller-manager-operator.yml
Validating images/ose-cluster-kube-scheduler-operator.yml...
✅ Validated images/ose-cluster-kube-scheduler-operator.yml
Validating images/ose-must-gather.yml...
✅ Validated images/ose-must-gather.yml
Validating images/ose-oauth-apiserver.yml...
✅ Validated images/ose-oauth-apiserver.yml
Validating images/ptp-operator-must-gather.yml...
✅ Validated images/ptp-operator-must-gather.yml
Validating images/ptp-operator.yml...
✅ Validated images/ptp-operator.yml
Validating images/sriov-dp-admission-controller.yml...
✅ Validated images/sriov-dp-admission-controller.yml
Validating images/sriov-network-config-daemon.yml...
✅ Validated images/sriov-network-config-daemon.yml
Validating images/sriov-network-device-plugin.yml...
✅ Validated images/sriov-network-device-plugin.yml
Validating images/sriov-network-operator.yml...
✅ Validated images/sriov-network-operator.yml
Validating images/sriov-network-webhook.yml...
✅ Validated images/sriov-network-webhook.yml

@thegreyd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@thegreyd thegreyd merged commit a9a12a3 into openshift-eng:openshift-4.17 Jul 16, 2024
@openshift-cherrypick-robot

@ashwindasr: new pull request created: #5105

Details

In response to this:

/cherry-pick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants