Skip to content

Conversation

@ashwindasr
Copy link

@ashwindasr ashwindasr commented Jul 3, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53998

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr ashwindasr changed the title Rename Dockerfile OCPBUGS-36524: Rename Dockerfile Jul 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 3, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36524, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53998

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gangwgr
Copy link

gangwgr commented Jul 5, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 4b2af11 link true /test images
ci/prow/e2e-aws-serial-techpreview 4b2af11 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn 4b2af11 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade 4b2af11 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn-techpreview 4b2af11 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial 4b2af11 link true /test e2e-aws-serial
ci/prow/verify 4b2af11 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36524, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53998

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Author

/hold

Needs to merge with an ocp-build-data PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr
Copy link
Author

/close

Will keep https://issues.redhat.com/browse/OCPBUGS-36524 open since ideally we have to move away from using a version specific Dockerfile. Will let image owners triage and prioritize accordingly

@openshift-ci openshift-ci bot closed this Oct 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

@ashwindasr: Closed this PR.

Details

In response to this:

/close

Will keep https://issues.redhat.com/browse/OCPBUGS-36524 open since ideally we have to move away from using a version specific Dockerfile. Will let image owners triage and prioritize accordingly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr ashwindasr deleted the rename-dockerfile branch October 22, 2024 13:29
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36524. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53998

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants