Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 2, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53937

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

@openshift-ci openshift-ci bot requested review from everettraven and oceanc80 July 2, 2024 18:48
@ashwindasr ashwindasr changed the title Rename Dockerfile OCPBUGS-36458: Rename Dockerfile Jul 2, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 2, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-36458, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53937

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@oceanc80
Copy link
Contributor

oceanc80 commented Jul 8, 2024

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 8, 2024
Copy link
Member

@KeenonLee KeenonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved
no need docs so,
/label docs-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-36458, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53937

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 567c188 into openshift:master Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: Jira Issue OCPBUGS-36458: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36458 has been moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#53937

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-helm-operator-container-v4.17.0-202407090841.p0.g567c188.assembly.stream.el9 for distgit openshift-enterprise-helm-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants