Skip to content

Conversation

@ashwindasr
Copy link
Contributor

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54073 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

@openshift-ci openshift-ci bot requested review from sferich888 and soltysh July 5, 2024 18:12
@soltysh soltysh changed the title Rename Dockerfile NO-JIRA: Rename Dockerfile Jul 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request explicitly references no jira issue.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54073 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh
Copy link
Contributor

soltysh commented Jul 9, 2024

/retest
now that we have openshift/release#54073 in

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8dea17e into openshift:master Jul 9, 2024
@ashwindasr ashwindasr deleted the rename-dockerfile branch July 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants