Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.10.0 release proposal #50682

Merged
merged 232 commits into from
Nov 22, 2023
Merged

v20.10.0 release proposal #50682

merged 232 commits into from
Nov 22, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 12, 2023

2023-11-22, Version 20.10.0 'Iron' (LTS), @targos

Notable Changes

--experimental-default-type flag to flip module defaults

The new flag --experimental-default-type can be used to flip the default
module system used by Node.js. Input that is already explicitly defined as ES
modules or CommonJS, such as by a package.json "type" field or .mjs/.cjs
file extension or the --input-type flag, is unaffected. What is currently
implicitly CommonJS would instead be interpreted as ES modules under
--experimental-default-type=module:

  • String input provided via --eval or STDIN, if --input-type is unspecified.

  • Files ending in .js or with no extension, if there is no package.json file
    present in the same folder or any parent folder.

  • Files ending in .js or with no extension, if the nearest parent
    package.json field lacks a type field; unless the folder is inside a
    node_modules folder.

In addition, extensionless files are interpreted as Wasm if
--experimental-wasm-modules is passed and the file contains the "magic bytes"
Wasm header.

Contributed by Geoffrey Booth in #49869.

Detect ESM syntax in ambiguous JavaScript

The new flag --experimental-detect-module can be used to automatically run ES
modules when their syntax can be detected. For “ambiguous” files, which are
.js or extensionless files with no package.json with a type field, Node.js
will parse the file to detect ES module syntax; if found, it will run the file
as an ES module, otherwise it will run the file as a CommonJS module. The same
applies to string input via --eval or STDIN.

We hope to make detection enabled by default in a future version of Node.js.
Detection increases startup time, so we encourage everyone—especially package
authors—to add a type field to package.json, even for the default
"type": "commonjs". The presence of a type field, or explicit extensions
such as .mjs or .cjs, will opt out of detection.

Contributed by Geoffrey Booth in #50096.

New flush option in file system functions

When writing to files, it is possible that data is not immediately flushed to
permanent storage. This allows subsequent read operations to see stale data.
This PR adds a 'flush' option to the fs.writeFile family of functions which
forces the data to be flushed at the end of a successful write operation.

Contributed by Colin Ihrig in #50009 and #50095.

Experimental WebSocket client

Adds a --experimental-websocket flag that adds a WebSocket
global, as standardized by WHATWG.

Contributed by Matthew Aitken in #49830.

vm: fix V8 compilation cache support for vm.Script

Previously repeated compilation of the same source code using vm.Script
stopped hitting the V8 compilation cache after v16.x when support for
importModuleDynamically was added to vm.Script, resulting in a performance
regression that blocked users (in particular Jest users) from upgrading from
v16.x.

The recent fixes allow the compilation cache to be hit again
for vm.Script when --experimental-vm-modules is not used even in the
presence of the importModuleDynamically option, so that users affected by the
performance regression can now upgrade. Ongoing work is also being done to
enable compilation cache support for vm.CompileFunction.

Contributed by Joyee Cheung in #49950
and #50137.

Other notable changes

  • [21453ae555] - (SEMVER-MINOR) deps: update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
  • [ee65e44c31] - esm: use import attributes instead of import assertions (Antoine du Hamel) #50140
  • [ffdc357167] - (SEMVER-MINOR) stream: allow passing stream class to stream.compose (Alex Yang) #50187
  • [4861ad6431] - stream: improve performance of readable stream reads (Raz Luvaton) #50173
  • [4b27087b30] - stream: optimize Writable (Robert Nagy) #50012
  • [709c6c0cab] - (SEMVER-MINOR) test_runner, cli: add --test-concurrency flag (Colin Ihrig) #49996
  • [57efd5292c] - (SEMVER-MINOR) vm: use import attributes instead of import assertions (Antoine du Hamel) #50141

Commits

  • [73757a5f42] - benchmark: fix race condition on fs benchs (Vinicius Lourenço) #50035
  • [23269717bb] - benchmark: add warmup to accessSync bench (Rafael Gonzaga) #50073
  • [88611d199a] - benchmark: improved config for blob,file benchmark (Vinícius Lourenço) #49730
  • [b70757476c] - benchmark: added new benchmarks for blob (Vinícius Lourenço) #49730
  • [458d9a82e3] - buffer: remove unnecessary assignment in fromString (Tobias Nießen) #50199
  • [878c0b332e] - build: fix IBM i build with Python 3.9 (Richard Lau) #48056
  • [773320e1de] - crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey (Filip Skokan) #50234
  • [edb0ffd7d4] - crypto: use X509_ALGOR accessors instead of reaching into X509_ALGOR (David Benjamin) #50057
  • [3f98c06dbb] - crypto: account for disabled SharedArrayBuffer (Shelley Vohr) #50034
  • [55485ff1cc] - crypto: return clear errors when loading invalid PFX data (Tim Perry) #49566
  • [68ec1e5eeb] - deps: upgrade npm to 10.2.3 (npm team) #50531
  • [b00c11ad7c] - deps: V8: cherry-pick d90d4533b053 (Michaël Zasso) #50077
  • [e63aef91b4] - deps: V8: cherry-pick f7d000a7ae7b (Luke Albao) #50077
  • [4b243b553a] - deps: V8: cherry-pick 9721082687c9 (Shi Pujin) #50077
  • [9d3cdcbebf] - deps: V8: cherry-pick 840650f2ff4e (Michaël Zasso) #50077
  • [0c40b513fd] - deps: V8: cherry-pick a1efa5343880 (Michaël Zasso) #50077
  • [68cddd79f7] - deps: update archs files for openssl-3.0.12+quic1 (Node.js GitHub Bot) #50411
  • [3308189180] - deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1 (Node.js GitHub Bot) #50411
  • [b61707e535] - deps: update ada to 2.7.2 (Node.js GitHub Bot) #50338
  • [1aecf0c17b] - deps: update corepack to 0.22.0 (Node.js GitHub Bot) #50325
  • [f5924f174c] - deps: update c-ares to 1.20.1 (Node.js GitHub Bot) #50082
  • [b705e19a95] - deps: update c-ares to 1.20.0 (Node.js GitHub Bot) #50082
  • [f72cbb7e02] - deps: V8: cherry-pick 25902244ad1a (Joyee Cheung) #50156
  • [6547bd2493] - deps: V8: cherry-pick ea996ad04a68 (Antoine du Hamel) #50183
  • [16fd730e95] - deps: V8: cherry-pick a0fd3209dda8 (Antoine du Hamel) #50183
  • [614c3620c3] - deps: update corepack to 0.21.0 (Node.js GitHub Bot) #50088
  • [545aa74ae2] - deps: update simdutf to 3.2.18 (Node.js GitHub Bot) #50091
  • [9302806c0a] - deps: update zlib to 1.2.13.1-motley-fef5869 (Node.js GitHub Bot) #50085
  • [03bf5c5d9a] - deps: update googletest to 2dd1c13 (Node.js GitHub Bot) #50081
  • [cd8e90690b] - deps: update googletest to e47544a (Node.js GitHub Bot) #49982
  • [40672cfe53] - deps: update ada to 2.6.10 (Node.js GitHub Bot) #49984
  • [34c7eb0eb2] - deps: fix call to undeclared functions 'ntohl' and 'htons' (MatteoBax) #49979
  • [03654b44b6] - deps: update ada to 2.6.9 (Node.js GitHub Bot) #49340
  • [4c740b1dd8] - deps: update ada to 2.6.8 (Node.js GitHub Bot) #49340
  • [759cf5a760] - deps: update ada to 2.6.7 (Node.js GitHub Bot) #49340
  • [31a4e9781a] - deps: update ada to 2.6.5 (Node.js GitHub Bot) #49340
  • [2ca867f2ab] - deps: update ada to 2.6.3 (Node.js GitHub Bot) #49340
  • [21453ae555] - (SEMVER-MINOR) deps: update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
  • [7ca1228be8] - deps: V8: cherry-pick 8ec2651fbdd8 (Abdirahim Musse) #49862
  • [3cc41d253c] - deps: upgrade npm to 10.2.0 (npm team) #50027
  • [61b4afb7dd] - deps: update undici to 5.26.4 (Node.js GitHub Bot) #50274
  • [ea28738336] - doc: add loong64 info into platform list (Shi Pujin) #50086
  • [00c12b7a20] - doc: update release process LTS step (Richard Lau) #50299
  • [a9ba29ba10] - doc: fix release process table of contents (Richard Lau) #50216
  • [4b5033519e] - doc: update api stream.compose (Alex Yang) #50206
  • [d4659e2080] - doc: add ReflectConstruct to known perf issues (Vinicius Lourenço) #50111
  • [ffa94612fd] - doc: fix typo in dgram docs (Peter Johnson) #50211
  • [f37b577b14] - doc: fix H4ad collaborator sort (Vinicius Lourenço) #50218
  • [c75264b1f9] - doc: add H4ad to collaborators (Vinícius Lourenço) #50217
  • [5025e24ac7] - doc: update release-stewards with last sec-release (Rafael Gonzaga) #50179
  • [63379313d5] - doc: add command to keep major branch sync (Rafael Gonzaga) #50102
  • [85de4b8254] - doc: add loong64 to list of architectures (Shi Pujin) #50172
  • [ff8e1b860e] - doc: update security release process (Michael Dawson) #50166
  • [33470d965c] - doc: improve ccache explanation (Chengzhong Wu) #50133
  • [7b97c44e2a] - doc: move danielleadams to TSC non-voting member (Danielle Adams) #50142
  • [3d03ca9f31] - doc: fix description of fs.readdir recursive option (RamdohokarAngha) #48902
  • [aab045ec4b] - doc: mention files read before env setup (Rafael Gonzaga) #50072
  • [26a7608a24] - doc: move permission model to Active Development (Rafael Gonzaga) #50068
  • [d7bbf7f2c4] - doc: add command to get patch minors and majors (Rafael Gonzaga) #50067
  • [9830165e34] - doc: use precise promise terminology in fs (Benjamin Gruenbaum) #50029
  • [585cbb211d] - doc: use precise terminology in test runner (Benjamin Gruenbaum) #50028
  • [2862f07124] - doc: clarify explaination text on how to run the example (Anshul Sinha) #39020
  • [fe47c8ad91] - doc: reserve 119 for Electron 28 (David Sanders) #50020
  • [36ecd2c588] - doc: update Collaborator pronouns (Tierney Cyren) #50005
  • [315d82a73e] - doc: update link to Abstract Modules Records spec (Rich Trott) #49961
  • [f63a92bb6c] - doc: updated building docs for windows (Claudio W) #49767
  • [ad17126501] - doc: update CHANGELOG_V20 about vm fixes (Joyee Cheung) #49951
  • [24458e2ac3] - doc: document dangerous symlink behavior (Tobias Nießen) #49154
  • [337a676d1f] - doc: add main ARIA landmark to API docs (Rich Trott) #49882
  • [959ef7ac6b] - doc: add navigation ARIA landmark to doc ToC (Rich Trott) #49882
  • [a60fbf2ab3] - doc: mark Node.js 19 as End-of-Life (Richard Lau) #48283
  • [c255575699] - errors: improve performance of determine-specific-type (Aras Abbasi) #49696
  • [e66991e6b2] - errors: improve formatList in errors.js (Aras Abbasi) #49642
  • [c71e548b65] - errors: improve performance of instantiation (Aras Abbasi) #49654
  • [3b867e4256] - esm: do not give wrong hints when detecting file format (Antoine du Hamel) #50314
  • [a589a1a905] - (SEMVER-MINOR) esm: detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096
  • [c64490e9aa] - esm: improve check for ESM syntax (Geoffrey Booth) #50127
  • [ee65e44c31] - esm: use import attributes instead of import assertions (Antoine du Hamel) #50140
  • [4de838fdeb] - esm: bypass CommonJS loader under --default-type (Geoffrey Booth) #49986
  • [27e02b633d] - esm: unflag extensionless javascript and wasm in module scope (Geoffrey Booth) #49974
  • [1e762ddf63] - esm: improve getFormatOfExtensionlessFile speed (Yagiz Nizipli) #49965
  • [112cc7f9f2] - esm: improve JSDoc annotation of internal functions (Antoine du Hamel) #49959
  • [c48cd84188] - esm: fix cache collision on JSON files using file: URL (Antoine du Hamel) #49887
  • [dc80ccef25] - esm: --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
  • [01039795a2] - esm: require braces for modules code (Geoffrey Booth) #49657
  • [e49ebf8f9a] - fs: improve error performance for readSync (Jungku Lee) #50033
  • [eb33f70260] - fs: improve error performance for fsyncSync (Jungku Lee) #49880
  • [8d0edc6399] - fs: improve error performance for mkdirSync (CanadaHonk) #49847
  • [36df27509e] - fs: improve error performance of realpathSync (Yagiz Nizipli) #49962
  • [4242cb7d7f] - fs: improve error performance of lchownSync (Yagiz Nizipli) #49962
  • [89e7878e44] - fs: improve error performance of symlinkSync (Yagiz Nizipli) #49962
  • [af6a0611fe] - fs: improve error performance of readlinkSync (Yagiz Nizipli) #49962
  • [12cda31c52] - fs: improve error performance of mkdtempSync (Yagiz Nizipli) #49962
  • [9dba771acb] - fs: improve error performance of linkSync (Yagiz Nizipli) #49962
  • [ea7902de13] - fs: improve error performance of chownSync (Yagiz Nizipli) #49962
  • [39f31a38cf] - fs: improve error performance of renameSync (Yagiz Nizipli) #49962
  • [35164fa466] - (SEMVER-MINOR) fs: add flush option to appendFile() functions (Colin Ihrig) #50095
  • [06aa4b9fe9] - fs: improve error performance of readdirSync (Yagiz Nizipli) #50131
  • [b5aecebcd6] - fs: fix unlinkSync typings (Yagiz Nizipli) #49859
  • [6ddea07225] - fs: improve error perf of sync chmod+fchmod (CanadaHonk) #49859
  • [841367078e] - fs: improve error perf of sync *times (CanadaHonk) #49864
  • [eb52f73e3e] - fs: improve error performance of writevSync (IlyasShabi) #50038
  • [d1aa62f1f5] - fs: add flush option to createWriteStream() (Colin Ihrig) #50093
  • [57eb06edff] - fs: improve error performance for ftruncateSync (André Alves) #50032
  • [22e3eb659a] - fs: add flush option to writeFile() functions (Colin Ihrig) #50009
  • [d7132d9214] - fs: improve error performance for fdatasyncSync (Jungku Lee) #49898
  • [bc2c0410d3] - fs: throw errors from sync branches instead of separate implementations (Joyee Cheung) #49913
  • [f46bcf1749] - http: refactor to make servername option normalization testable (Rongjian Zhang) #38733
  • [1bfcf817af] - http2: allow streams to complete gracefully after goaway (Michael Lumish) #50202
  • [5c66ec9e66] - inspector: simplify dispatchProtocolMessage (Daniel Lemire) #49780
  • [251ae1dd72] - lib: improve performance of validateStringArray and validateBooleanArray (Aras Abbasi) #49756
  • [d9c791a508] - lib: fix compileFunction throws range error for negative numbers (Jithil P Ponnan) #49855
  • [24cbc550c2] - lib: reduce overhead of validateObject (Vinicius Lourenço) #49928
  • [b80e9497f3] - lib: make fetch sync and return a Promise (Matthew Aitken) #49936
  • [d9eda6761b] - lib: fix primordials typings (Sam Verschueren) #49895
  • [3e0d47c1f4] - lib: update params in jsdoc for HTTPRequestOptions (Jungku Lee) #49872
  • [a01050dec4] - (SEMVER-MINOR) lib: add WebSocket client (Matthew Aitken) #49830
  • [5bca8feed2] - lib,test: do not hardcode Buffer.kMaxLength (Michaël Zasso) #49876
  • [e8ebed7a24] - meta: move Trott to TSC regular member (Rich Trott) #50297
  • [27e957cea8] - meta: ping TSC for offboarding (Tobias Nießen) #50147
  • [fab39062d5] - meta: bump actions/upload-artifact from 3.1.2 to 3.1.3 (dependabot[bot]) #50000
  • [46ec82496c] - meta: bump actions/cache from 3.3.1 to 3.3.2 (dependabot[bot]) #50003
  • [a634fb431e] - meta: bump github/codeql-action from 2.21.5 to 2.21.9 (dependabot[bot]) #50002
  • [c221f72911] - meta: bump actions/checkout from 3.6.0 to 4.1.0 (dependabot[bot]) #50001
  • [d356e5e395] - meta: update website team with new name (Rich Trott) #49883
  • [2ff4e71452] - module: move helpers out of cjs loader (Geoffrey Booth) #49912
  • [142ac3f82d] - module, esm: jsdoc for modules files (Geoffrey Booth) #49523
  • [e2f0ef2a60] - node-api: update headers for better wasm support (Toyo Li) #49037
  • [db2a07fcd6] - node-api: run finalizers directly from GC (Vladimir Morozov) #42651
  • [c25716be8b] - os: cache homedir, remove getCheckedFunction (Aras Abbasi) #50037
  • [e8f024b4db] - perf_hooks: reduce overhead of new user timings (Vinicius Lourenço) #49914
  • [a517be0a5a] - perf_hooks: reducing overhead of performance observer entry list (Vinicius Lourenço) #50008
  • [42e49ec381] - perf_hooks: reduce overhead of new resource timings (Vinicius Lourenço) #49837
  • [c99e51ed1b] - src: generate default snapshot with --predictable (Joyee Cheung) #48749
  • [47164e238f] - src: fix TLSWrap lifetime bug in ALPN callback (Ben Noordhuis) #49635
  • [e1df69e73e] - src: set port in node_options to uint16_t (Yagiz Nizipli) #49151
  • [1eb2af29b4] - src: name scoped lock (Mohammed Keyvanzadeh) #50010
  • [5131fde655] - src: use exact return value for uv_os_getenv (Yagiz Nizipli) #49149
  • [ba169be5ca] - src: move const variable in node_file.h to node_file.cc (Jungku Lee) #49688
  • [5a2351d3ab] - src: remove unused variable (Michaël Zasso) #49665
  • [f2f993a32f] - stream: simplify prefinish (Robert Nagy) #50204
  • [6d7274e3ca] - stream: reduce scope of readable bitmap details (Robert Nagy) #49963
  • [ffdc357167] - (SEMVER-MINOR) stream: allow pass stream class to stream.compose (Alex Yang) #50187
  • [4861ad6431] - stream: call helper function from push and unshift (Raz Luvaton) #50173
  • [e60b3ab31b] - stream: use private symbol for bitmap state (Robert Nagy) #49993
  • [ecbfb23f6b] - stream: lazy allocate back pressure buffer (Robert Nagy) #50013
  • [88c739bef4] - stream: avoid unnecessary drain for sync stream (Robert Nagy) #50014
  • [4b27087b30] - stream: optimize Writable (Robert Nagy) #50012
  • [def55f80a1] - stream: avoid tick in writable hot path (Robert Nagy) #49966
  • [35ec93115d] - stream: writable state bitmap (Robert Nagy) #49899
  • [6e0f0fafe4] - test: use ppc and ppc64 to skip SEA tests on PowerPC (Joyee Cheung) #50828
  • [a528bbceca] - test: mark SEA tests as flaky on PowerPC (Joyee Cheung) #50750
  • [4e34f9a26e] - test: relax version check with shared OpenSSL (Luigi Pinca) #50505
  • [41ca1132eb] - test: fix crypto-dh error message for OpenSSL 3.x (Kerem Kat) #50395
  • [a6a05e8a88] - test: fix testsuite against zlib version 1.3 (Dominique Leuenberger) #50364
  • [8dd895e574] - test: replace forEach with for..of in test-process-env (Niya Shiyas) #49825
  • [81886c66d1] - test: replace forEach with for..of in test-http-url (Niya Shiyas) #49840
  • [7d8a18b257] - test: improve watch mode test (Moshe Atlow) #50319
  • [baa04b79ca] - test: set test-watch-mode-inspect as flaky (Yagiz Nizipli) #50259
  • [3d9130bc2e] - Revert "test: set test-esm-loader-resolve-type as flaky" (Antoine du Hamel) #50315
  • [72626f9a35] - test: replace forEach with for..of in test-http-perf_hooks.js (Niya Shiyas) #49818
  • [379a7255e8] - test: replace forEach with for..of in test-net-isipv4.js (Niya Shiyas) #49822
  • [b55fcd75da] - test: deflake test-esm-loader-resolve-type (Antoine du Hamel) #50273
  • [0134af3eeb] - test: replace forEach with for..of in test-http2-server (Niya Shiyas) #49819
  • [8c15281d06] - test: replace forEach with for..of in test-http2-client-destroy.js (Niya Shiyas) #49820
  • [c37a75a898] - test: update url web platform tests (Yagiz Nizipli) #50264
  • [ab5985d0e9] - test: set test-emit-after-on-destroyed as flaky (Yagiz Nizipli) #50246
  • [50181a19b8] - test: set inspector async stack test as flaky (Yagiz Nizipli) #50244
  • [b9e0fed995] - test: set test-worker-nearheaplimit-deadlock flaky (StefanStojanovic) #50277
  • [2cfc4007d1] - test: set test-cli-node-options as flaky (Yagiz Nizipli) #50296
  • [788714b28f] - test: reduce the number of requests and parsers (Luigi Pinca) #50240
  • [0dce19c8f6] - test: set crypto-timing test as flaky (Yagiz Nizipli) #50232
  • [5d4b5ff1b8] - test: set test-structuredclone-* as flaky (Yagiz Nizipli) #50261
  • [5c56081d67] - test: deflake test-loaders-workers-spawned (Antoine du Hamel) #50251
  • [3441e1982d] - test: improve code coverage of diagnostics_channel (Jithil P Ponnan) #50053
  • [696ba93329] - test: set test-esm-loader-resolve-type as flaky (Yagiz Nizipli) #50226
  • [8b260c5d6b] - test: set inspector async hook test as flaky (Yagiz Nizipli) #50252
  • [f3296d25e8] - test: skip test-benchmark-os.js on IBM i (Abdirahim Musse) #50208
  • [fefe17b02e] - test: set parallel http server test as flaky (Yagiz Nizipli) #50227
  • [228c87f329] - test: set test-worker-nearheaplimit-deadlock flaky (Stefan Stojanovic) #50238
  • [c2c2506eab] - test: set test-runner-watch-mode as flaky (Yagiz Nizipli) #50221
  • [16a07983d4] - test: set sea snapshot tests as flaky (Yagiz Nizipli) #50223
  • [7cd406a0b8] - test: fix defect path traversal tests (Tobias Nießen) #50124
  • [1cf3f8da32] - test: replace forEach with for..of in test-net-isipv6.js (Niya Shiyas) #49823
  • [214997a99e] - test: reduce number of repetition in test-heapdump-shadowrealm.js (Chengzhong Wu) #50104
  • [9d836516e6] - test: replace forEach with for..of in test-parse-args.mjs (Niya Shiyas) #49824
  • [fee8b24603] - test: replace forEach() in test-net-perf_hooks with for of (Narcisa Codreanu) #49831
  • [4c58b92ba8] - test: change forEach to for...of (Tiffany Lastimosa) #49799
  • [01b01527d7] - test: update skip for moved test-wasm-web-api (Richard Lau) #49958
  • [179e293103] - Revert "test: mark test-runner-output as flaky" (Luigi Pinca) #49905
  • [829eb99afd] - test: disambiguate AIX and IBM i (Richard Lau) #48056
  • [126407d438] - test: deflake test-perf-hooks.js (Joyee Cheung) #49892
  • [393fd5b7c9] - test: migrate message error tests from Python to JS (Yiyun Lei) #49721
  • [5dfe4236f8] - test: fix edge snapshot stack traces (Geoffrey Booth) #49659
  • [d164e537bf] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #50039
  • [55a03fedae] - test_runner: add test location for FileTests (Colin Ihrig) #49999
  • [10b35cfb6e] - test_runner: replace spurious if with else (Colin Ihrig) #49943
  • [27558c4314] - test_runner: catch reporter errors (Moshe Atlow) #49646
  • [709c6c0cab] - (SEMVER-MINOR) test_runner, cli: add --test-concurrency flag (Colin Ihrig) #49996
  • [64ef108dd9] - test_runner,test: fix flaky test-runner-cli-concurrency.js (Colin Ihrig) #50108
  • [d2def152d9] - tls: reduce TLS 'close' event listener warnings (Tim Perry) #50136
  • [294b650f5c] - tls: handle cases where the raw socket is destroyed (Luigi Pinca) #49980
  • [52b5693949] - tls: ciphers allow bang syntax (Chemi Atlow) #49712
  • [05ee35028b] - tools: update comment in update-uncidi.sh and acorn_version.h (Jungku Lee) #50175
  • [35b160e6a3] - tools: refactor checkimports.py (Mohammed Keyvanzadeh) #50011
  • [b959d36b77] - tools: fix comments referencing dep_updaters scripts (Keksonoid) #50165
  • [bd5d5331b0] - tools: remove no-return-await lint rule (翠 / green) #50118
  • [b9adf3d66e] - tools: update lint-md-dependencies (Node.js GitHub Bot) #50083
  • [4978bdc4ec] - tools: update eslint to 8.51.0 (Node.js GitHub Bot) #50084
  • [e323a367fd] - tools: remove genv8constants.py (Ben Noordhuis) #50023
  • [1cc6cbff26] - tools: update eslint to 8.50.0 (Node.js GitHub Bot) #49989
  • [924231be2a] - tools: update lint-md-dependencies (Node.js GitHub Bot) #49983
  • [732b5661ea] - tools: add navigation ARIA landmark to generated API ToC (Rich Trott) #49882
  • [353a14278e] - tools: update github_reporter to 1.5.3 (Node.js GitHub Bot) #49877
  • [0aaab45d7c] - tools: improve macOS notarization process output readability (Ulises Gascón) #50389
  • [ad326033e2] - tools: remove unused version function (Ulises Gascón) #50390
  • [2f32472544] - tools: drop support for osx notarization with gon (Ulises Gascón) #50291
  • [3b1c15aeb0] - tools: use osx notarytool for future releases (Ulises Gascon) #48701
  • [0ddb87ede3] - typings: use Symbol.dispose and Symbol.asyncDispose in types (Niklas Mollenhauer) #50123
  • [bf5b2115a0] - util: remove internal mime fns from benchmarks (Aras Abbasi) #50201
  • [ac02cdb0ad] - util: lazy parse mime parameters (Aras Abbasi) #49889
  • [9853fd96df] - vm: reject in importModuleDynamically without --experimental-vm-modules (Joyee Cheung) #50137
  • [3697c19c80] - vm: use internal versions of compileFunction and Script (Joyee Cheung) #50137
  • [56bbc30a44] - vm: unify host-defined option generation in vm.compileFunction (Joyee Cheung) #50137
  • [57efd5292c] - (SEMVER-MINOR) vm: use import attributes instead of import assertions (Antoine du Hamel) #50141
  • [17581c2716] - vm: use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950
  • [65e18aa8e7] - wasi: address coverity warning (Michael Dawson) #49866
  • [5b695d6a8d] - wasi: fix up wasi tests for ibmi (Michael Dawson) #49953
  • [b86e1f5cbd] - (SEMVER-MINOR) wasi: updates required for latest uvwasi version (Michael Dawson) #49908
  • [b4d149b4d6] - worker: handle detached MessagePort from a different context (Juan José) #49150
  • [f564ed4e05] - zlib: fix discovery of cpu-features.h for android (MatteoBax) #49828

richardlau and others added 30 commits October 25, 2023 07:55
PR-URL: #48283
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #50027
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Signed-off-by: Ulises Gascon <[email protected]>

Refs: nodejs/build#3385
PR-URL: #48701
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Refs: nodejs/build#3385 (comment)
PR-URL: #50291
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #50390
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #49657
Backport-PR-URL: #50268
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #49665
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: #49659
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #49523
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #49646
Fixes: #48937
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: #47707
PR-URL: #49721
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Original commit message:

    fix: EmbeddedTargetOs on IBM i with Python 3.9

    For some context, Python 3.9 on IBM i returns "os400" for sys.platform
    instead of "aix". We used to build with Python 3.6 which returned "aix"
    as the platform

    When attempting to build Node.js with python 3.9 on IBM i we run into a
    build error.

    Ref: #48056
    Ref: #48056 (comment)

    I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs.
    It seems as though target_os is being generated from sys.platform or
    similar call from python as we started running into this issue after
    building with Python 3.9.

    This PR supersedes initial changes proposed in:
    https://chromium-review.googlesource.com/c/v8/v8/+/4259330

    This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep)
    on IBM i with Python 3.9.

    Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413
    Commit-Queue: Jakob Linke <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Reviewed-by: Jakob Linke <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89981}

Refs: v8/v8@8ec2651
PR-URL: #49862
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #49654
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
V8 will soon support typed arrays as large as the maximum array buffer
length. This patch replaces hardcoded values related to
Buffer.kMaxLength with the actual constant.
It also fixes a test that was passing by accident.

Refs: v8/v8@44b2995
PR-URL: #49876
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
fixup

add test

lint

fixup

update doc/node.1

PR-URL: #49830
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #49877
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
As an accessibility improvement, specify the navigation landmark for
the column in our docs that contains the table of contents.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: #49882
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
As an accessibility improvement, specify the main landmark for
the column in our docs that contains the main content.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: #49882
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
As an accessibility improvement, specify the navigation landmark for
the element of our docs that contains the table of contents generated
for the specific API page.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: #49882
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: #49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #49869
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #49887
Fixes: #49724
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #49642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #49872
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Much earlier, a design decision was made that the permission model
should not prevent following symbolic links to presumably inaccessible
locations. Recently, after some back and forth, it had been decided that
it is indeed a vulnerability that symbolic links, which currently point
to an accessible location, can potentially be re-targeted to point to a
presumably inaccessible location. Nevertheless, months later, no
solution has been found and the issue is deemed unfixable in the context
of the current permission model implementation, so it was decided to
disclose the vulnerability and to shift responsibiliy onto users who are
now responsible for ensuring that no potentially dangerous symlinks
exist in any directories that they grant access to.

I believe that this design issue might be surprising and that it comes
with significant security implications for users, so it should be
documented.

Original vulnerability report: https://hackerone.com/reports/1961655

PR-URL: #49154
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
joyeecheung and others added 4 commits November 21, 2023 09:16
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
It seems using ppc alone is not enough. Add ppc64 to be safe.

PR-URL: #50828
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
PR-URL: #50531
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) #50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096
  * use import attributes instead of import assertions (Antoine du Hamel) #50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095
  * add flush option to writeFile() functions (Colin Ihrig) #50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187
  * call helper function from push and unshift (Raz Luvaton) #50173
  * optimize Writable (Robert Nagy) #50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950
wasi:

PR-URL: #50682
@targos
Copy link
Member Author

targos commented Nov 21, 2023

Updated. Release will be done tomorrow.

@nodejs nodejs deleted a comment from nodejs-github-bot Nov 21, 2023
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 21, 2023
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member Author

targos commented Nov 22, 2023

Release build: https://ci-release.nodejs.org/job/iojs+release/9783/

@targos targos merged commit a220664 into v20.x Nov 22, 2023
49 checks passed
@targos targos deleted the v20.10.0-proposal branch November 22, 2023 14:52
targos added a commit that referenced this pull request Nov 22, 2023
targos added a commit that referenced this pull request Nov 22, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) #50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096
  * use import attributes instead of import assertions (Antoine du Hamel) #50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095
  * add flush option to writeFile() functions (Colin Ihrig) #50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187
  * call helper function from push and unshift (Raz Luvaton) #50173
  * optimize Writable (Robert Nagy) #50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950
wasi:

PR-URL: #50682
targos added a commit to targos/nodejs.org that referenced this pull request Nov 22, 2023
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 22, 2023
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 22, 2023
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 22, 2023
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 22, 2023
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096
  * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095
  * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187
  * call helper function from push and unshift (Raz Luvaton) nodejs#50173
  * optimize Writable (Robert Nagy) nodejs#50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950
wasi:

PR-URL: nodejs#50682
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096
  * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095
  * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187
  * call helper function from push and unshift (Raz Luvaton) nodejs#50173
  * optimize Writable (Robert Nagy) nodejs#50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950
wasi:

PR-URL: nodejs#50682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.