-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: drop support for osx notarization with gon #50291
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
UlisesGascon:tools/osx-remove-gon
Oct 21, 2023
Merged
tools: drop support for osx notarization with gon #50291
nodejs-github-bot
merged 1 commit into
nodejs:main
from
UlisesGascon:tools/osx-remove-gon
Oct 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
macos
Issues and PRs related to the macOS platform / OSX.
tools
Issues and PRs related to the tools directory.
labels
Oct 19, 2023
targos
approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
lpinca
approved these changes
Oct 19, 2023
anonrig
approved these changes
Oct 19, 2023
richardlau
approved these changes
Oct 19, 2023
richardlau
added
lts-watch-v18.x
PRs that may need to be released in v18.x.
lts-watch-v20.x
PRs that may need to be released in v20.x
labels
Oct 19, 2023
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 21, 2023
Landed in fc423db |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added
backported-to-v18.x
PRs backported to the v18.x-staging branch.
and removed
lts-watch-v18.x
PRs that may need to be released in v18.x.
labels
Oct 28, 2023
targos
pushed a commit
that referenced
this pull request
Oct 28, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Refs: nodejs/build#3385 (comment) PR-URL: nodejs#50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Nov 7, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added
backported-to-v20.x
PRs backported to the v20.x-staging branch.
and removed
lts-watch-v20.x
PRs that may need to be released in v20.x
labels
Nov 12, 2023
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/build#3385 (comment) PR-URL: nodejs/node#50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/build#3385 (comment) PR-URL: nodejs/node#50291 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported-to-v18.x
PRs backported to the v18.x-staging branch.
backported-to-v20.x
PRs backported to the v20.x-staging branch.
macos
Issues and PRs related to the macOS platform / OSX.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Drops support for gon in the OSX notarization process as this tool will not be supported after November 1, 2023. Only notarytool will be used from that moment.
Context
Refs: nodejs/build#3385 (comment)
Refs: Continuation for #48701
cc: @nodejs/build