Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update website team with new name #49883

Merged
merged 1 commit into from
Sep 28, 2023
Merged

meta: update website team with new name #49883

merged 1 commit into from
Sep 28, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 26, 2023

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@Trott
Copy link
Member Author

Trott commented Sep 26, 2023

@ovflowd

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 26, 2023
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 26, 2023
@Trott Trott requested a review from ovflowd September 26, 2023 18:29
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@ovflowd
Copy link
Member

ovflowd commented Sep 26, 2023 •
edited
Loading

@Trott can you update the PR? The correct team here would be @nodejs/web-infra

(Due to this being a more technical + infrastructure part (the API tooling))

@Trott
Copy link
Member Author

Trott commented Sep 26, 2023 •
edited
Loading

@Trott can you update the PR? The correct team here would be @nodejs/web-infra

(Due to this being a more technical + infrastructure part (the API tooling))

Are you sure about that? I mean, maybe the tools line, but are you sure you want infra to be pinged for the template.html file or the asset files? I'm updating this because the ping on #49882 didn't happen and that seems more like a website issue than an infra issue. If you say I'm wrong, I'll make them all infra, but I would think it would be all website and maybe infra in addition on the tools one?

@ovflowd
Copy link
Member

ovflowd commented Sep 26, 2023

@Trott can you update the PR? The correct team here would be @nodejs/web-infra
(Due to this being a more technical + infrastructure part (the API tooling))

Are you sure about that? I mean, maybe the tools line, but are you sure you want infra to be pinged for the template.html file or the asset files? I'm updating this because the ping on #49882 didn't happen and that seems more like a website issue than an infra issue. If you say I'm wrong, I'll make them all infra, but I would think it would be all website and maybe infra in addition on the tools one?

That's fair. Let's keep for the template to the website and tooling to web-infra

ovflowd
ovflowd reviewed Sep 27, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Trott Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49883
✔  Done loading data for nodejs/node/pull/49883
----------------------------------- PR info ------------------------------------
Title      meta: update website team with new name (#49883)
Author     Rich Trott  (@Trott)
Branch     Trott:codeowners -> nodejs:main
Labels     meta, fast-track, commit-queue-squash
Commits    5
 - meta: update website team with new name
 - Merge branch 'main' into codeowners
 - Merge branch 'main' into codeowners
 - Update .github/CODEOWNERS
 - Merge branch 'main' into codeowners
Committers 2
 - Rich Trott 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49883
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Claudio Wunder 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49883
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Claudio Wunder 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update .github/CODEOWNERS
   ⚠  - Merge branch 'main' into codeowners
   ℹ  This PR was created on Tue, 26 Sep 2023 18:28:51 GMT
   ✔  Approvals: 7
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1644961950
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645005247
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645020927
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645030663
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645620447
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647064713
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647488560
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6344268112

@Trott
meta: update website team with new name
0fe673c 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: nodejs#49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott merged commit 0fe673c into nodejs:main Sep 28, 2023
8 checks passed
@Trott
Copy link
Member Author

Trott commented Sep 28, 2023

Landed in 0fe673c

@Trott Trott deleted the codeowners branch September 28, 2023 21:24
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@Trott @alexfernandez
meta: update website team with new name
8548225 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: nodejs#49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Trott @targos
meta: update website team with new name
d356e5e 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: #49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@Trott @targos
meta: update website team with new name
d24c3a0 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: #49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@Trott @debadree25
meta: update website team with new name
4d48632 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: nodejs#49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: update website team with new name
85338d1 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: nodejs/node#49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: update website team with new name
b1119d6 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: nodejs/node#49883
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @ovflowd @lpinca @anonrig @tniessen @MoLow @aduh95 @RaisinTen