-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace forEach with for..of in test-net-isipv6.js #49823
Conversation
test/parallel/test-net-isipv6.js
Outdated
assert.strictEqual(net.isIPv6(ip), true); | ||
}); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made required changes.
test/parallel/test-net-isipv6.js
Outdated
assert.strictEqual(net.isIPv6(ip), false); | ||
}); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made required changes.
Please review this again. |
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/49823 ✔ Done loading data for nodejs/node/pull/49823 ----------------------------------- PR info ------------------------------------ Title test: replace forEach with for..of in test-net-isipv6.js (#49823) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch niyashiyas:test-7 -> nodejs:main Labels test, code-and-learn, needs-ci, commit-queue-squash Commits 4 - test: replace forEach with for..of in test-net-isipv6.js - test: replace forEach with for..of in test-net-isipv6.js - Update test/parallel/test-net-isipv6.js - Update test/parallel/test-net-isipv6.js Committers 2 - Niya Shiyas - GitHub PR-URL: https://github.com/nodejs/node/pull/49823 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49823 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update test/parallel/test-net-isipv6.js ⚠ - Update test/parallel/test-net-isipv6.js ℹ This PR was created on Sat, 23 Sep 2023 08:56:26 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49823#pullrequestreview-1663033007 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-09T13:17:19Z: https://ci.nodejs.org/job/node-test-pull-request/54630/ - Querying data for job/node-test-pull-request/54630/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6509223254 |
PR-URL: #49823 Reviewed-By: Luigi Pinca <[email protected]>
Landed in 41e4174. |
PR-URL: nodejs#49823 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #49823 Reviewed-By: Luigi Pinca <[email protected]>
Replaced forEach with for..of in test-net-isipv6.js