Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace forEach with for..of in test-net-isipv6.js #49823

Closed
wants to merge 4 commits into from

Conversation

niyashiyas
Copy link
Contributor

Replaced forEach with for..of in test-net-isipv6.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
assert.strictEqual(net.isIPv6(ip), true);
});
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

assert.strictEqual(net.isIPv6(ip), false);
});
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

@niyashiyas
Copy link
Contributor Author

Please review this again.

@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-net-isipv6.js test: replace forEach with for..of in test-net-isipv6.js Sep 30, 2023
test/parallel/test-net-isipv6.js Outdated Show resolved Hide resolved
test/parallel/test-net-isipv6.js Outdated Show resolved Hide resolved
@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49823
✔  Done loading data for nodejs/node/pull/49823
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for..of in test-net-isipv6.js (#49823)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-7 -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    4
 - test: replace forEach with for..of in test-net-isipv6.js
 - test: replace forEach with for..of in test-net-isipv6.js
 - Update test/parallel/test-net-isipv6.js
 - Update test/parallel/test-net-isipv6.js
Committers 2
 - Niya Shiyas 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49823
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49823
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update test/parallel/test-net-isipv6.js
   ⚠  - Update test/parallel/test-net-isipv6.js
   ℹ  This PR was created on Sat, 23 Sep 2023 08:56:26 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49823#pullrequestreview-1663033007
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-09T13:17:19Z: https://ci.nodejs.org/job/node-test-pull-request/54630/
- Querying data for job/node-test-pull-request/54630/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6509223254

lpinca pushed a commit that referenced this pull request Oct 13, 2023
@lpinca
Copy link
Member

lpinca commented Oct 13, 2023

Landed in 41e4174.

@lpinca lpinca closed this Oct 13, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants