Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move Trott to TSC regular member #50297

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 19, 2023

At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years.

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 19, 2023
@richardlau richardlau mentioned this pull request Oct 19, 2023
3 tasks
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the work you've done in the role, Rich - thank you ❤️

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit b30acb7 into nodejs:main Oct 19, 2023
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b30acb7

@Trott Trott deleted the regular branch October 19, 2023 18:11
targos pushed a commit that referenced this pull request Oct 23, 2023
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: #50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@joyeecheung
Copy link
Member

I am late to the party, just want to show my appreciation of all the work you've been doing for the project over the years ❤️

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: #50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: #50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs/node#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs/node#50297
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants