- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
test_runner: add test location for FileTests #49999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    This commit adds the previously missing test location for FileTest tests. Fixes: nodejs#49926 Fixes: nodejs#49927
| 
           Review requested: 
  | 
    
              
                    MoLow
  
              
              approved these changes
              
                  
                    Oct 1, 2023 
                  
              
              
            
            
      
        
      
      
  
    12 tasks
  
              
                    atlowChemi
  
              
              approved these changes
              
                  
                    Oct 2, 2023 
                  
              
              
            
            
              
                    benjamingr
  
              
              approved these changes
              
                  
                    Oct 2, 2023 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Oct 2, 2023 
                  
              
              
            
            
      
        
      
      
  
    18 tasks
  
| 
           Landed in 4b35a9c  | 
    
  This was referenced Oct 4, 2023 
      
    
  alexfernandez 
      pushed a commit
        to alexfernandez/node
      that referenced
      this pull request
    
      Nov 1, 2023 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: nodejs#49926 Fixes: nodejs#49927 PR-URL: nodejs#49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Nov 11, 2023 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: #49926 Fixes: #49927 PR-URL: #49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Nov 27, 2023 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: #49926 Fixes: #49927 PR-URL: #49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  debadree25 
      pushed a commit
        to debadree25/node
      that referenced
      this pull request
    
      Apr 15, 2024 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: nodejs#49926 Fixes: nodejs#49927 PR-URL: nodejs#49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  sercher 
      added a commit
        to sercher/graaljs
      that referenced
      this pull request
    
      Apr 25, 2024 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: nodejs/node#49926 Fixes: nodejs/node#49927 PR-URL: nodejs/node#49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  sercher 
      added a commit
        to sercher/graaljs
      that referenced
      this pull request
    
      Apr 25, 2024 
    
    
      
  
    
      
    
  
This commit adds the previously missing test location for FileTest tests. Fixes: nodejs/node#49926 Fixes: nodejs/node#49927 PR-URL: nodejs/node#49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    test_runner
  Issues and PRs related to the test runner subsystem. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This commit adds the previously missing test location for
FileTesttests.Fixes: #49926
Fixes: #49927