Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set test-emit-after-on-destroyed as flaky #50246

Merged
merged 1 commit into from
Oct 20, 2023
Merged

test: set test-emit-after-on-destroyed as flaky #50246

merged 1 commit into from
Oct 20, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023 •
edited
Loading

Ref: #50245

cc @nodejs/async_hooks

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54952/

@aduh95
Copy link
Contributor

aduh95 commented Oct 18, 2023

@nodejs/platform-aix

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54980/

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Open
25 tasks
@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55013/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55026/

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Open
20 tasks
mhdawson
mhdawson approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55051/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2d24518 into nodejs:main Oct 20, 2023
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2d24518

This was referenced Oct 21, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set test-emit-after-on-destroyed as flaky
3b80a68 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set test-emit-after-on-destroyed as flaky
c518cd0 
Ref: nodejs#50245
PR-URL: nodejs#50246
Refs: nodejs#50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set test-emit-after-on-destroyed as flaky
ab5985d 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set test-emit-after-on-destroyed as flaky
1047d95 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-emit-after-on-destroyed as flaky
48bbefb 
Ref: nodejs/node#50245
PR-URL: nodejs/node#50246
Refs: nodejs/node#50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-emit-after-on-destroyed as flaky
31826c7 
Ref: nodejs/node#50245
PR-URL: nodejs/node#50246
Refs: nodejs/node#50245
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @aduh95 @panva @GeoffreyBooth @mhdawson