test: use ppc and ppc64 to skip SEA tests on PowerPC #50828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems using ppc alone is not enough. Add ppc64 to be safe.
nodejs-github-bot
added
needs-ci
|
For context I looked at the CI and found https://ci.nodejs.org/job/node-test-commit-plinux/50941/ which was rebasing onto a commit that should contain #50750 yet the SEA tests are still not marked as flaky. To be safe, just check both ppc and ppc64 here. |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Nov 20, 2023
lpinca
approved these changes
Nov 20, 2023
joyeecheung
added
the
fast-track
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
kvakil
approved these changes
Nov 20, 2023
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 78633c4 |
targos
pushed a commit
that referenced
this pull request
Nov 21, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: #50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: #50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: nodejs#50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: nodejs#50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: #50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
It seems using ppc alone is not enough. Add ppc64 to be safe. PR-URL: #50828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]>
Merged
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 11, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: nodejs#51422 Refs: nodejs#50828 Refs: nodejs#50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: nodejs#51422 Refs: nodejs#50828 Refs: nodejs#50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau
added a commit
that referenced
this pull request
Mar 25, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau
added a commit
that referenced
this pull request
Mar 25, 2024
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems using ppc alone is not enough. Add ppc64 to be safe.