test: relax version check with shared OpenSSL #50505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: nodejs#43078
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Nov 1, 2023
github-actions
bot
removed
the
request-ci
25 tasks
This was referenced Nov 3, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3e3467e |
richardlau
added
lts-watch-v18.x
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: #43078 PR-URL: #50505 Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: #43078 PR-URL: #50505 Reviewed-By: Richard Lau <[email protected]>
targos
added
backported-to-v20.x
targos
pushed a commit
that referenced
this pull request
Nov 15, 2023
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: #43078 PR-URL: #50505 Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 15, 2023
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: #43078 PR-URL: #50505 Reviewed-By: Richard Lau <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: nodejs/node#43078 PR-URL: nodejs/node#50505 Reviewed-By: Richard Lau <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: nodejs/node#43078 PR-URL: nodejs/node#50505 Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the OpenSSL version check when Node.js is built with the
--shared-openssloption. Verify only thatprocess.versions.opensslis truthy.Fixes: #43078