-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14.17.4 proposal #39466
v14.17.4 proposal #39466
Commits on Jul 20, 2021
-
deps: V8: backport 1b1eda0876aa
Original commit message: tracing: Update proto library build rule and roll Perfetto This patch removes use of the deprecated sources_assignment_filter GN feature from gni/proto_library.gni, since the extra descriptor files are no longer being generated. We also roll Perfetto to match the version used in Chrome and update test expectations accordingly. Bug: v8:10995 Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079 Commit-Queue: Michael Achenbach <[email protected]> Auto-Submit: Sami Kyöstilä <[email protected]> Reviewed-by: Peter Marshall <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/master@{#70381} Refs: v8/v8@1b1eda0 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17eb561 - Browse repository at this point
Copy the full SHA 17eb561View commit details -
deps: V8: cherry-pick 92e6d3317082
Original commit message: build: Remove no-op calls to set_sources_assignment_filter Chromiun no longer use set_sources_assignment_filter() anywhere in the build, so these are no longer needed. Bug: chromium:1018739 Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988 Reviewed-by: Nico Weber <[email protected]> Commit-Queue: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/master@{#70405} Refs: v8/v8@92e6d33 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a83b01a - Browse repository at this point
Copy the full SHA a83b01aView commit details -
deps: V8: cherry-pick 7c182bd65f42
Original commit message: Fix visiblity rules for configs enforced by the latest GN version. Prior versions of GN had a bug (gn:22) where visibility rules for configs weren't being enforced properly. This CL tweaks the visibility settings of some configs to conform to the latest version. Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909 Commit-Queue: Dirk Pranke <[email protected]> Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/master@{#69463} Refs: v8/v8@7c182bd PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4be2e87 - Browse repository at this point
Copy the full SHA 4be2e87View commit details -
deps: V8: cherry-pick 0b3a4ecf7083
Original commit message: Fix implicit conversion loses integer precision warning The type of m is long in 64 bits build, and results implicit conversion loses integer precision, which was found by improved clang warning (-Wshorten-64-to-32) Bug: chromium:1124085 Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323 Commit-Queue: Zequan Wu <[email protected]> Auto-Submit: Zequan Wu <[email protected]> Reviewed-by: Nico Weber <[email protected]> Reviewed-by: Igor Sheludko <[email protected]> Cr-Commit-Position: refs/heads/master@{#69686} Refs: v8/v8@0b3a4ec PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fdd6ec - Browse repository at this point
Copy the full SHA 7fdd6ecView commit details -
deps: V8: cherry-pick 895949419186
Original commit message: Add -Wno-string-concatenation to test/cctest:cctest_sources v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation. Bug: chromium:1114873 Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829 Commit-Queue: Arthur Eubanks <[email protected]> Reviewed-by: Sathya Gunasekaran <[email protected]> Cr-Commit-Position: refs/heads/master@{#69625} Refs: v8/v8@8959494 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a60a960 - Browse repository at this point
Copy the full SHA a60a960View commit details -
deps: V8: update build dependencies
These updates are necessary to build V8 with recent GN versions. PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7557e74 - Browse repository at this point
Copy the full SHA 7557e74View commit details -
deps: restore minimum ICU version to 65
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ccecea5 - Browse repository at this point
Copy the full SHA ccecea5View commit details -
deps: V8: cherry-pick 81181a8ad80a
Original commit message: [JSON] Fix GC issue in BuildJsonObject We must ensure that the sweeper is not running or has already swept mutable_double_buffer. Otherwise the GC can add it to the free list. Bug: v8:11837 Change-Id: Ifd9cf15f1c94f664fd6489c70bb38b59730cdd78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928181 Commit-Queue: Victor Gomes <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Reviewed-by: Dominik Inführ <[email protected]> Cr-Commit-Position: refs/heads/master@{#74859} Refs: v8/v8@81181a8 PR-URL: #39187 Fixes: #37553 Refs: v8/v8@81181a8 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4213e97 - Browse repository at this point
Copy the full SHA 4213e97View commit details -
debugger: move node-inspect to internal library
node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: #36481 PR-URL: #38161 Backport-PR-URL: #38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8bd2a39 - Browse repository at this point
Copy the full SHA 8bd2a39View commit details -
tools: remove node-inspect from license
PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc219d8 - Browse repository at this point
Copy the full SHA fc219d8View commit details -
Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0321c5b - Browse repository at this point
Copy the full SHA 0321c5bView commit details -
debugger: fix inspect restart on Windows
Fixes: #37224 PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1da6921 - Browse repository at this point
Copy the full SHA 1da6921View commit details -
debugger: accommodate line chunking in Windows
PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b172e6f - Browse repository at this point
Copy the full SHA b172e6fView commit details -
debugger: allow longer time to connect
Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 22afb7c - Browse repository at this point
Copy the full SHA 22afb7cView commit details -
test: fix test-inspector-cli-address
The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 193ea8f - Browse repository at this point
Copy the full SHA 193ea8fView commit details -
test,debugger: migrate node-inspect tests to core
Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a62826b - Browse repository at this point
Copy the full SHA a62826bView commit details -
debugger: replace internal use of deprecated API
Change process.binding() use to internalBinding(). PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a8924fa - Browse repository at this point
Copy the full SHA a8924faView commit details -
PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd2642b - Browse repository at this point
Copy the full SHA dd2642bView commit details -
debugger: fix race condition/deadlock on initialization
PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9e28c6c - Browse repository at this point
Copy the full SHA 9e28c6cView commit details -
test: extend timeout on debugger tests for slower machines
PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d3a1fa - Browse repository at this point
Copy the full SHA 4d3a1faView commit details -
test: fix flaky inspector-cli tests when breakpionts are restored
PR-URL: #38431 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99fd8bf - Browse repository at this point
Copy the full SHA 99fd8bfView commit details -
doc: update code examples for
node:url
moduleThere are many things called `url` in this page including `url` module, `URL` instances, etc. The original example was not clear where these methods come from. PR-URL: #38645 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d9129e - Browse repository at this point
Copy the full SHA 4d9129eView commit details -
src: replace
auto
s in node_contextify.ccPR-URL: #38644 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d82200 - Browse repository at this point
Copy the full SHA 7d82200View commit details -
test: give js-native-api tests consistent names
The convention for js-native-api/<test_name>: * <test_name>.c or <test_name>.cc has the entry point * The name of the target is <test_name> PR-URL: #38692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e265d8e - Browse repository at this point
Copy the full SHA e265d8eView commit details -
doc: document null target pattern
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8049b69 - Browse repository at this point
Copy the full SHA 8049b69View commit details -
src: write named pipe info in diagnostic report
Writes pipe handles with `uv_pipe_getsockname()` and `uv_pipe_getpeername()`. PR-URL: #38637 Fixes: #38625 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 846a138 - Browse repository at this point
Copy the full SHA 846a138View commit details -
src: remove commented code in
node_file.cc
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c11d3e - Browse repository at this point
Copy the full SHA 2c11d3eView commit details -
src: use HandleScope in StreamReq::Done()
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2d32031 - Browse repository at this point
Copy the full SHA 2d32031View commit details -
typings: add JSDoc typings for events
Added JSDoc typings for the `events` lib module. PR-URL: #38712 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ea1368 - Browse repository at this point
Copy the full SHA 6ea1368View commit details -
test: improve coverage of lib/_http_outgoing.js
Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_outgoing.js.html#L351 Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_outgoing.js.html#L609 PR-URL: #38734 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aeea252 - Browse repository at this point
Copy the full SHA aeea252View commit details -
build: replace non-POSIX test -a|o
test/[ from sbase unix tools[1] throws "too many arguments" if -a or -o is provided. The syntax has been marked obsolescent as per the manual[2]. [1] http://core.suckless.org/sbase/ [2] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16 PR-URL: #38731 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5b1d1f - Browse repository at this point
Copy the full SHA b5b1d1fView commit details -
benchmark: fix http elapsed time
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: #38369 PR-URL: #38743 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9693cf - Browse repository at this point
Copy the full SHA f9693cfView commit details -
child_process: retain reference to data with advanced serialization
Do the same thing we do for other streams, and retain a reference to the Buffer that was sent over IPC while the write request is active, so that it doesn’t get garbage collected while the data is still in flight. (This is a good example of why it’s a bad idea that we’re not re-using the general streams implementation for IPC and instead maintain separate usage of the low-level I/O primitives.) Fixes: #34797 PR-URL: #38728 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55ea29e - Browse repository at this point
Copy the full SHA 55ea29eView commit details -
typings: add JSDoc typings for https
Added JSDoc typings for the `https` lib module. PR-URL: #38589 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58154ce - Browse repository at this point
Copy the full SHA 58154ceView commit details -
build: allow LTO with Clang 3.9.1+
Bug: #38568 Test: manual, - arm64-apple-darwin20.5.0 / Apple clang version 12.0.5 (clang-1205.0.22.9) - x86_64-pc-linux-gnu / Ubuntu clang version 13.0.0-++20210520052624+48780527dd68-1~exp1~20210520153429.417 Signed-off-by: Jesse Chan <[email protected]> PR-URL: #38751 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a6f8ba8 - Browse repository at this point
Copy the full SHA a6f8ba8View commit details -
doc: fixup code sample in http.md
PR-URL: #38776 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 826ae9b - Browse repository at this point
Copy the full SHA 826ae9bView commit details -
test: os, replace custom flatten method with built-in Array.flat
PR-URL: #38770 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb91932 - Browse repository at this point
Copy the full SHA eb91932View commit details -
benchmark: output JSON-compatible numbers
This is to simplify the implementation of a JavaScript version of the compare.R script. PR-URL: #38778 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86477b2 - Browse repository at this point
Copy the full SHA 86477b2View commit details -
test: improve coverage for
question
in readlinePR-URL: #38799 Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 504bfd7 - Browse repository at this point
Copy the full SHA 504bfd7View commit details -
PR-URL: #38818 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8699e62 - Browse repository at this point
Copy the full SHA 8699e62View commit details -
test: simplify test-path-resolve.js
PR-URL: #38671 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01f00fa - Browse repository at this point
Copy the full SHA 01f00faView commit details -
PR-URL: #38567 Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f53a0b - Browse repository at this point
Copy the full SHA 7f53a0bView commit details -
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fecad40 - Browse repository at this point
Copy the full SHA fecad40View commit details -
tools: update setup-node to setup-node@v2
Signed-off-by: pengjie <[email protected]> PR-URL: #38825 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1dc71da - Browse repository at this point
Copy the full SHA 1dc71daView commit details -
doc: use "Long Term Support" in README
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: #38839 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dfe9698 - Browse repository at this point
Copy the full SHA dfe9698View commit details -
doc: use "Long Term Support" in technical values doc
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7a9850a - Browse repository at this point
Copy the full SHA 7a9850aView commit details -
doc: use "Long Term Support" in collaborator guide
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b4f60bb - Browse repository at this point
Copy the full SHA b4f60bbView commit details -
tools: remove exception for Node.js 8 and earlier
Remove exception in .eslintrc.js to accommodate versions of Node.js prior to 10.x. 10.x and later all support omitting catch block arguments. PR-URL: #38840 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2ec7c9d - Browse repository at this point
Copy the full SHA 2ec7c9dView commit details -
PR-URL: #38851 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b7686d0 - Browse repository at this point
Copy the full SHA b7686d0View commit details -
tools: refloat 7 Node.js patches to cpplint.py
Cherry-pick 12c8b4d Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: #17373 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Refs: 12c8b4d Cherry-pick fc81e80 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: #21521 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: fc81e80 Cherry-pick cbc3dd9 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: #21010 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: cbc3dd9 Cherry-pick 9029981 Original commit message: tools: fix cpplint.py header rules THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: #26306 Reviewed-By: Gireesh Punathil <[email protected]> Refs: 9029981 Cherry-pick 0a25ace Original commit message: tools: move cpplint configuration to .cpplint PR-URL: #27098 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Refs: 0a25ace Cherry-pick afa9a72 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: #30876 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Refs: afa9a72 Cherry-pick e23bf8f Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: #31018 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> PR-URL: #35569 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> PR-URL: #35719 Reviewed-By: Antoine du Hamel <[email protected]> PR-URL: #35866 PR-URL: #36213 Reviewed-By: Franziska Hinkelmann <[email protected]> PR-URL: #36235 Reviewed-By: Luigi Pinca <[email protected]> PR-URL: #36324 Reviewed-By: Beth Griggs <[email protected]> PR-URL: #38851 Reviewed-By: Khaidi Chu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2ad0719 - Browse repository at this point
Copy the full SHA 2ad0719View commit details -
debugger: removed unused function argument
PR-URL: #38850 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb0ab4c - Browse repository at this point
Copy the full SHA fb0ab4cView commit details -
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e36d2a6 - Browse repository at this point
Copy the full SHA e36d2a6View commit details -
PR-URL: #38845 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 73e199d - Browse repository at this point
Copy the full SHA 73e199dView commit details -
PR-URL: #38846 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0a1984 - Browse repository at this point
Copy the full SHA b0a1984View commit details -
src: replace
auto
s in node_api.ccPR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 981217e - Browse repository at this point
Copy the full SHA 981217eView commit details -
test: improve coverage of fs internal utils
Refs: https://coverage.nodejs.org/coverage-910efc2d9a69ac32/lib/internal/fs/utils.js.html#L634 PR-URL: #38746 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0cca16a - Browse repository at this point
Copy the full SHA 0cca16aView commit details -
build: remove outdated dont-land-on-v6.x label
PR-URL: #38886 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ffbe3d - Browse repository at this point
Copy the full SHA 1ffbe3dView commit details -
worker: do not look up context twice in PostMessage
Refs: #38780 (comment) PR-URL: #38784 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c28e00 - Browse repository at this point
Copy the full SHA 2c28e00View commit details -
src: add not-weak DCHECK to PersistentToLocal::Strong
Refs: #38821 (comment) PR-URL: #38875 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff7cc8f - Browse repository at this point
Copy the full SHA ff7cc8fView commit details -
tools,doc: forbid CJS globals in ESM code snippets
PR-URL: #38889 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4bb0bd0 - Browse repository at this point
Copy the full SHA 4bb0bd0View commit details -
doc: clarify when
readable._read(...)
is calledFixes: #38586 PR-URL: #38726 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b2d836b - Browse repository at this point
Copy the full SHA b2d836bView commit details -
tools: bump remark-preset-lint-node to 2.3.0
PR-URL: #38910 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b4ae8f - Browse repository at this point
Copy the full SHA 9b4ae8fView commit details -
build: correct Xcode spelling in .gitignore
PR-URL: #38895 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49a0006 - Browse repository at this point
Copy the full SHA 49a0006View commit details -
child_process: refactor to use
validateBoolean
PR-URL: #38927 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc2b1ec - Browse repository at this point
Copy the full SHA fc2b1ecView commit details -
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd00547 - Browse repository at this point
Copy the full SHA dd00547View commit details -
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c061d5 - Browse repository at this point
Copy the full SHA 6c061d5View commit details -
node-api: avoid SecondPassCallback crash
PR #38000 added indirection so that we could stop finalization in cases where it had been scheduled in a second pass callback but we were doing it in advance in environment teardown. Unforunately we missed that the code which tries to clear the second pass parameter checked if the pointer to the parameter (_secondPassParameter) was nullptr and that when the second pass callback was scheduled we set _secondPassParameter to nullptr in order to avoid it being deleted outside of the second pass callback. The net result was that we would not clear the _secondPassParameter contents and failed to avoid the Finalization in the second pass callback. This PR adds an additional boolean for deciding if the secondPassParameter should be deleted outside of the second pass callback instead of setting secondPassParameter to nullptr thus avoiding the conflict between the 2 ways it was being used. See the discussion starting at: #38273 (comment) for how this was discovered on OSX while trying to upgrade to a new V8 version. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #38899 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd3305a - Browse repository at this point
Copy the full SHA cd3305aView commit details -
test: suppress warning in test_environment.cc
Currently there is a compiler warning generated if a build defines NDEBUG: $ env CXXFLAGS='-DNDEBUG' make -j8 cctest ../test/cctest/test_environment.cc: In function ‘void at_exit_js(void*)’: ../test/cctest/test_environment.cc:333:25: warning: variable ‘obj’ set but not used [-Wunused-but-set-variable] 333 | v8::Local<v8::Object> obj = v8::Object::New(isolate); | ^~~ NDEBUG is currently not defined using the main branch but this discovered when working on replacing OpenSSL 1.1.1 with OpenSSL 3.0. This commit uses EXPECT statements instead of asserts to avoid the warning. PR-URL: #38868 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 660a97b - Browse repository at this point
Copy the full SHA 660a97bView commit details -
build: don't pass python override to V8 build
If the `configure.py` script is executed by a Python binary that is not the one on the PATH it will create a `python` symlink in `out/tools/bin` and prefix that to the PATH so it is used instead of the one that otherwise would have been found on the PATH. This is done so that gyp scripts shelling out to `python` execute with the same version of Python as used to run the configure script. V8's build uses V8's build toolchain (i.e. not gyp) and currently that is incompatible with Python 3. Prevent prefixing the PATH for the V8 build so that it picks up `python` from the unprefixed PATH. This will allow us to build Node.js with Python 3 but still use Python 2 to build V8 in the CI. PR-URL: #38969 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0736dd8 - Browse repository at this point
Copy the full SHA 0736dd8View commit details -
doc: mark util.inherits as legacy
PR-URL: #38896 Refs: #38893 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b405296 - Browse repository at this point
Copy the full SHA b405296View commit details -
url,src: simplify ipv6 logic by using uv_inet_pton
PR-URL: #38842 Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6942a6 - Browse repository at this point
Copy the full SHA b6942a6View commit details -
src: throw error in LoadBuiltinModuleSource when reading fails
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bee477b - Browse repository at this point
Copy the full SHA bee477bView commit details -
debugger: apply automatic lint fixes for _inspect.js
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8dd1f70 - Browse repository at this point
Copy the full SHA 8dd1f70View commit details -
debugger: apply automatic lint fixes for inspect_repl.js
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 61da371 - Browse repository at this point
Copy the full SHA 61da371View commit details -
tools: update ESLint to 7.28.0
PR-URL: #38955 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1023433 - Browse repository at this point
Copy the full SHA 1023433View commit details -
build: fix commit-queue default branch
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d341561 - Browse repository at this point
Copy the full SHA d341561View commit details -
doc: add missing semis after classes
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #38931 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 41fcbad - Browse repository at this point
Copy the full SHA 41fcbadView commit details -
test: http outgoing _headers setter null
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: #38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c99a09f - Browse repository at this point
Copy the full SHA c99a09fView commit details -
Replaced params in writeFileSync function in proper way. PR-URL: #38941 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd48ee7 - Browse repository at this point
Copy the full SHA cd48ee7View commit details -
test: improve coverage of lib/events.js
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b3b5995 - Browse repository at this point
Copy the full SHA b3b5995View commit details -
tools: fix typo in commit-queue.sh
PR-URL: #39000 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 547f88b - Browse repository at this point
Copy the full SHA 547f88bView commit details -
doc: clarify that only one Python version is required to build
PR-URL: #38894 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e474e98 - Browse repository at this point
Copy the full SHA e474e98View commit details -
tools: avoid crashing CQ when git push fails
PR-URL: #36861 Reviewed-By: Mary Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 443db64 - Browse repository at this point
Copy the full SHA 443db64View commit details -
build: make build-addons errors fail the build
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and then uses `touch` to update a timestamp file. Unconditionally calling `touch` was losing the exit code from `tools/doc/addon-verify.js` so any errors produced by that script were not failing the build. PR-URL: #38983 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 069cf59 - Browse repository at this point
Copy the full SHA 069cf59View commit details -
test: remove obsolete TLS test
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: #39001 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ab28f9b - Browse repository at this point
Copy the full SHA ab28f9bView commit details -
module: fix legacy
node
specifier resolution to resolve"main"
fieldPR-URL: #38979 Fixes: #32103 Fixes: #38739 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for afb6178 - Browse repository at this point
Copy the full SHA afb6178View commit details -
doc: add missing parameter types
Both of the `clearTimeout()` and `clearInterval()` functions in the `timers` lib accepts the ID of the `Timeout` object returned by the functions in a number or string type, e.g. ```js const t = setTimeout(console.log, 5000, 'test'); clearTimeout(t[Symbol.toPrimitive]()); ``` PR-URL: #39013 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 797bd73 - Browse repository at this point
Copy the full SHA 797bd73View commit details -
src: refactor to use locale functions
This makes the code more readable. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #39014 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dcfb182 - Browse repository at this point
Copy the full SHA dcfb182View commit details -
tools: update doctool dependencies, migrate to ESM
- Migrated to ESM because some dependencies now require it. - Did not update `highlight.js` to v11 because it has many breaking changes. - Used non-deprecated `highlight.js` API. Refs: highlightjs/highlight.js#2277 Fixes: #38938 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #38966 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54a250e - Browse repository at this point
Copy the full SHA 54a250eView commit details -
Revert "build: work around bug in MSBuild v16.10.0"
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: #38872 PR-URL: #38977 Fixes: #38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6962c64 - Browse repository at this point
Copy the full SHA 6962c64View commit details -
PR-URL: #39045 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4009350 - Browse repository at this point
Copy the full SHA 4009350View commit details -
test: fix name of variable in inspector-cli test
PR-URL: #38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f1862e - Browse repository at this point
Copy the full SHA 6f1862eView commit details -
src: cleanup uv_fs_t regardless of success or not
PR-URL: #38996 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43fe6c1 - Browse repository at this point
Copy the full SHA 43fe6c1View commit details -
src,url: separate some tables out of node_url.cc
The purpose of separating is for readability and maintainability. PR-URL: #38988 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51da7d2 - Browse repository at this point
Copy the full SHA 51da7d2View commit details -
doc: remove references to deleted freenode channels
PR-URL: #39047 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 04032fa - Browse repository at this point
Copy the full SHA 04032faView commit details -
lib: add JSDoc typings for child_process
Added JSDoc typings for the `child_process` lib module. PR-URL: #38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bc2a23 - Browse repository at this point
Copy the full SHA 2bc2a23View commit details -
PR-URL: #38538 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6447cab - Browse repository at this point
Copy the full SHA 6447cabView commit details -
test: move inspector-cli tests to sequential
There's no reason to keep these tests separated from everything else. PR-URL: #39079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6b2fea3 - Browse repository at this point
Copy the full SHA 6b2fea3View commit details -
debugger: rename internal library for clarity
When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: #39080 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4c2b813 - Browse repository at this point
Copy the full SHA 4c2b813View commit details -
build: reconfigure when gyp files change on Windows
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: #39066 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a657f25 - Browse repository at this point
Copy the full SHA a657f25View commit details -
lib: make internal/options lazy
This way, internal modules can still require the module and cache the function getOptionValue() early (therefore these code can be included in the snapshots), but the options map won't be serialized from C++ land until the option values are actually queried. PR-URL: #38993 Refs: #35711 Refs: #38905 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 199fe32 - Browse repository at this point
Copy the full SHA 199fe32View commit details -
tools: update ESLint to 7.29.0
PR-URL: #39083 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8e63b3 - Browse repository at this point
Copy the full SHA b8e63b3View commit details -
lib: remove semicolon in preparation for babel/eslint-parser update
eslint-babel-plugin will complain about this semicolon when we update to 7.14.15. PR-URL: #39094 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 097a787 - Browse repository at this point
Copy the full SHA 097a787View commit details -
tools: update babel-eslint-parser to 7.14.5
PR-URL: #39094 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ab45ace - Browse repository at this point
Copy the full SHA ab45aceView commit details -
errors: don't rekey on primitive type
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes #38945 PR-URL: #39025 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb9a9ad - Browse repository at this point
Copy the full SHA bb9a9adView commit details -
src: use SPrintF in ProcessEmitWarning
PR-URL: #38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #39419
Configuration menu - View commit details
-
Copy full SHA for e7f266e - Browse repository at this point
Copy the full SHA e7f266eView commit details -
build: fix building with external builtins
PR-URL: #39091 Backport-PR-URL: #39419 Fixes: #39090 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ab4f81 - Browse repository at this point
Copy the full SHA 1ab4f81View commit details -
lib: add
globalThis
to primordialsPR-URL: #38211 Backport-PR-URL: #39448 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea9003a - Browse repository at this point
Copy the full SHA ea9003aView commit details -
lib: enforce using
primordials.globalThis
instead ofglobal
PR-URL: #38230 Backport-PR-URL: #39448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4f96bb - Browse repository at this point
Copy the full SHA d4f96bbView commit details -
lib: harden lint checks for globals
PR-URL: #38419 Backport-PR-URL: #39448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e3223ed - Browse repository at this point
Copy the full SHA e3223edView commit details -
deps: V8: cherry-pick b0a7f5691113
Original commit message: Update to ICU68-1 ICU68-1 change the output skeleton format. So we need to change resolvedOptions code for 68 migration. Chromium roll https://chromium-review.googlesource.com/c/chromium/src/+/2474093 Bug: v8:10945 Change-Id: I3b2c7fbe8abb22df8fa51287c498ca3245b8c55b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477431 Commit-Queue: Frank Tang <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Reviewed-by: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#70972} Refs: v8/v8@b0a7f56 PR-URL: #39051 Fixes: #39050 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b69069 - Browse repository at this point
Copy the full SHA 9b69069View commit details -
test: add NumberFormat resolvedOptions test
Add a regression test for NumberFormat resolvedOptions. PR-URL: #39401 Refs: #39050 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: #39051
Configuration menu - View commit details
-
Copy full SHA for 45c2ea3 - Browse repository at this point
Copy the full SHA 45c2ea3View commit details -
deps: V8: backport 16ffec97e5eb
Original commit message: Fix maximize/minimize of Intl.Locale Roll ICU to 46f53dfc chromium/src/DEPS already roll in https://chromium-review.googlesource.com/c/chromium/src/+/2235734 Bug: v8:10448 Change-Id: I147189527e57282c6cc7a1e92f832275d5ef55c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237353 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#68275} Refs: v8/v8@16ffec9 PR-URL: #39051 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5039f21 - Browse repository at this point
Copy the full SHA 5039f21View commit details -
deps: V8: backport ae7bfb3f03b3
Original commit message: Change test expectation per tz2020b https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html Revised predictions for Morocco's changes starting in 2023. Canada's Yukon changes to -07 on 2020-11-01, not 2020-03-08. Macquarie Island has stayed in sync with Tasmania since 2011. Casey, Antarctica is at +08 in winter and +11 in summer. zic no longer supports -y, nor the TYPE field of Rules. Bug: chromium:1137864, chromium:1138117 Change-Id: I6076a993fcd755074ddcfa5321b78aa5f043337b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476681 Commit-Queue: Frank Tang <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/master@{#70553} Refs: v8/v8@ae7bfb3 PR-URL: #39051 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4efefe0 - Browse repository at this point
Copy the full SHA 4efefe0View commit details
Commits on Jul 22, 2021
-
lib: add primordials.SafeArrayIterator
PR-URL: #36532 Backport-PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8cc2ff - Browse repository at this point
Copy the full SHA d8cc2ffView commit details -
Revert "debugger: rename internal library for clarity"
This reverts commit d0c7ab0. PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cde7221 - Browse repository at this point
Copy the full SHA cde7221View commit details -
debugger: add usage example for
--port
PR-URL: #38400 Backport-PR-URL: #39446 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21ecee1 - Browse repository at this point
Copy the full SHA 21ecee1View commit details -
debugger: refactor
internal/inspector/_inspect
to use more primordialsPR-URL: #38406 Backport-PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 721edef - Browse repository at this point
Copy the full SHA 721edefView commit details -
debugger: wait for V8 debugger to be enabled
Refs: #38273 (comment) PR-URL: #38811 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79bfb04 - Browse repository at this point
Copy the full SHA 79bfb04View commit details -
debugger: revise async iterator usage to comply with lint rules
I'm not sure that this is any clearer than the existing code, but I don't think it's significantly less clear, and it avoids comment disabling a lint rule. PR-URL: #38847 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ef5e08 - Browse repository at this point
Copy the full SHA 0ef5e08View commit details -
debugger: reduce scope of eslint disable comment
Current code masks setInterval and setTimeout with promisified versions. This can be confusing to read and causes lint errors. Replace masking with use of pSetInterval and pSetTimeout instead. Move disabling of lint rule from entire file to the one remaining line (after the above changes) that still needs it. PR-URL: #38946 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 249acd5 - Browse repository at this point
Copy the full SHA 249acd5View commit details -
debugger: enable linter on
internal/inspector/inspect_client
PR-URL: #38417 Backport-PR-URL: #39446 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e58f938 - Browse repository at this point
Copy the full SHA e58f938View commit details -
debugger: remove unnecessary boilerplate copyright comment
PR-URL: #38952 Backport-PR-URL: #39446 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d74d67f - Browse repository at this point
Copy the full SHA d74d67fView commit details -
debugger: align message with Node.js standard
Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the messages from inspect with other messages from the REPL and elsewhere, make that change in node-inspect too. PR-URL: #38400 Backport-PR-URL: #39446 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b30ff35 - Browse repository at this point
Copy the full SHA b30ff35View commit details -
debugger: wrap lines longer than 80 chars
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae90756 - Browse repository at this point
Copy the full SHA ae90756View commit details -
debugger: avoid non-ASCII char in code file
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 34659f2 - Browse repository at this point
Copy the full SHA 34659f2View commit details -
debugger: disable only the lint rules required by current file state
PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5724a1 - Browse repository at this point
Copy the full SHA b5724a1View commit details -
debugger: refactor to use internal modules
This avoids loading the entirety of `node:util` and `node:url` and their dependencies while only a subset is actually used by this module. PR-URL: #38550 Backport-PR-URL: #39446 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad80566 - Browse repository at this point
Copy the full SHA ad80566View commit details -
debugger: refactor
inspect_repl
to use primordialsPR-URL: #38551 Backport-PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9a4dcb - Browse repository at this point
Copy the full SHA f9a4dcbView commit details -
debugger: removed unused function argument
PR-URL: #38850 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 052e1c5 - Browse repository at this point
Copy the full SHA 052e1c5View commit details -
errors: add ERR_DEBUGGER_ERROR
PR-URL: #39024 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cfccf13 - Browse repository at this point
Copy the full SHA cfccf13View commit details -
debugger: use ERR_DEBUGGER_ERROR in debugger client
PR-URL: #39024 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a3991d7 - Browse repository at this point
Copy the full SHA a3991d7View commit details -
debugger: use error codes in debugger REPL
PR-URL: #39024 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d4d23d - Browse repository at this point
Copy the full SHA 5d4d23dView commit details -
errors: add ERR_DEBUGGER_STARTUP_ERROR
PR-URL: #39024 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b993ed - Browse repository at this point
Copy the full SHA 9b993edView commit details -
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
PR-URL: #39024 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b7ee9d8 - Browse repository at this point
Copy the full SHA b7ee9d8View commit details -
debugger: rename internal library for clarity
When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: #39080 Backport-PR-URL: #39446 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 716ee15 - Browse repository at this point
Copy the full SHA 716ee15View commit details -
doc,url: clarify domainTo* when built without ICU
Continuation of: #35099 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #38789 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2ff671e - Browse repository at this point
Copy the full SHA 2ff671eView commit details
Commits on Jul 23, 2021
-
http2: on receiving rst_stream with cancel code add it to pending list
PR-URL: #39423 Fixes: #38964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d48b91e - Browse repository at this point
Copy the full SHA d48b91eView commit details
Commits on Jul 28, 2021
-
PR-URL: #39553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for acf5279 - Browse repository at this point
Copy the full SHA acf5279View commit details
Commits on Jul 29, 2021
-
2021-07-29, Version 14.17.4 'Fermium' (LTS)
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
Configuration menu - View commit details
-
Copy full SHA for 488c27f - Browse repository at this point
Copy the full SHA 488c27fView commit details