Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: forbid CJS globals in ESM code snippets #38889

Merged
merged 2 commits into from
Jun 3, 2021
Merged

tools,doc: forbid CJS globals in ESM code snippets #38889

merged 2 commits into from
Jun 3, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 1, 2021

57f4e21 is pulled from #38882 which should land first.

@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label Jun 1, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. blocked PRs that are blocked by other issues or PRs. labels Jun 1, 2021
aduh95 added a commit to aduh95/node that referenced this pull request Jun 3, 2021
@aduh95
tools,doc: forbid CJS globals in ESM code snippets
d8c09f1 
PR-URL: nodejs#38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
himself65 and others added 2 commits June 3, 2021 16:18
@himself65 @aduh95
doc: fix .mjs syntax in crypto.md
47548d0 
Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: nodejs#38882
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95
tools,doc: forbid CJS globals in ESM code snippets
2481fac 
PR-URL: nodejs#38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95 aduh95 merged commit 2481fac into nodejs:master Jun 3, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 3, 2021

Landed in 2481fac

@aduh95 aduh95 deleted the no-cjs-on-my-lawn branch June 3, 2021 14:20
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
tools,doc: forbid CJS globals in ESM code snippets
00c20e6 
PR-URL: #38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@aduh95 @richardlau
tools,doc: forbid CJS globals in ESM code snippets
9708d52 
PR-URL: #38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@aduh95 @richardlau
tools,doc: forbid CJS globals in ESM code snippets
b521ea5 
PR-URL: #38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
tools,doc: forbid CJS globals in ESM code snippets
4bb0bd0 
PR-URL: #38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
tools,doc: forbid CJS globals in ESM code snippets
838bafd 
PR-URL: nodejs#38889
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Mesteery Mesteery mentioned this pull request Nov 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@danielleadams danielleadams danielleadams approved these changes

@himself65 himself65 himself65 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. blocked PRs that are blocked by other issues or PRs. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @jasnell @Trott @danielleadams @himself65 @RaisinTen @bl-ue