Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: output JSON-compatible numbers #38778

Closed
wants to merge 1 commit into from
Closed

benchmark: output JSON-compatible numbers #38778

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 23, 2021

This is to simplify the implementation of a JavaScript version of the
compare.R script.

See https://github.com/targos/node-benchmark-compare

You can try it with:

npm i -g node-benchmark-compare
node-benchmark-compare result.csv

I verified that the script gives the exact same numbers as the R script.

@targos
benchmark: output JSON-compatible numbers
3ab32da 
This is to simplify the implementation of a JavaScript version of the
compare.R script.
@github-actions github-actions bot added the benchmark Issues and PRs related to the benchmark subsystem. label May 23, 2021
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 24, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38323/ 💚

@jasnell
Copy link
Member

jasnell commented May 25, 2021

Landed in 2a1dea8

jasnell pushed a commit that referenced this pull request May 25, 2021
@targos @jasnell
benchmark: output JSON-compatible numbers
2a1dea8 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: #38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@jasnell jasnell closed this May 25, 2021
@targos targos deleted the benchmark-json branch May 25, 2021 21:06
danielleadams pushed a commit that referenced this pull request May 31, 2021
@targos @danielleadams
benchmark: output JSON-compatible numbers
4e58ec4 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: #38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@targos @richardlau
benchmark: output JSON-compatible numbers
1816f02 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: #38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@targos @richardlau
benchmark: output JSON-compatible numbers
1ffe29a 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: #38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@targos @richardlau
benchmark: output JSON-compatible numbers
86477b2 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: #38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@targos @foxxyz
benchmark: output JSON-compatible numbers
af5bf0f 
This is to simplify the implementation of a JavaScript version of the
compare.R script.

PR-URL: nodejs#38778
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@antsmartian antsmartian antsmartian approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @jasnell @addaleax @antsmartian @Lxxyx @aduh95 @VoltrexKeyva