Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use SPrintF in ProcessEmitWarning #38758

Closed
wants to merge 3 commits into from
Closed

src: use SPrintF in ProcessEmitWarning #38758

wants to merge 3 commits into from
+49 −32

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 21, 2021
addaleax
addaleax previously approved these changes May 22, 2021
View reviewed changes
addaleax
addaleax reviewed May 22, 2021
View reviewed changes
src/node_process.h Outdated Show resolved Hide resolved
@addaleax addaleax dismissed their stale review May 22, 2021 13:52

code changed

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 24, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38312/ 💚

@jasnell
Copy link
Member

jasnell commented May 25, 2021

Landed in fa7cdd6

@jasnell jasnell closed this May 25, 2021
jasnell pushed a commit that referenced this pull request May 25, 2021
@RaisinTen @jasnell
src: use SPrintF in ProcessEmitWarning
fa7cdd6 
PR-URL: #38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@RaisinTen RaisinTen deleted the src/use-SPrintF-in-ProcessEmitWarning branch May 25, 2021 14:17
danielleadams pushed a commit that referenced this pull request May 31, 2021
@RaisinTen @danielleadams
src: use SPrintF in ProcessEmitWarning
3e6b3b2 
PR-URL: #38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
@richardlau
Copy link
Member

Doesn't land cleanly on v14.x-staging.

RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
@RaisinTen
src: use SPrintF in ProcessEmitWarning
4e0a336 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@RaisinTen RaisinTen mentioned this pull request Jul 17, 2021
Closed
RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
@RaisinTen
src: use SPrintF in ProcessEmitWarning
9ce9b14 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Backport-PR-URL: nodejs#39419
@RaisinTen
Copy link
Contributor Author

@richardlau Backport PR: #39419

richardlau pushed a commit to RaisinTen/node that referenced this pull request Jul 19, 2021
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
50afb5a 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Backport-PR-URL: nodejs#39419
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
b0ef28a 
PR-URL: #38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
e7f266e 
PR-URL: #38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Backport-PR-URL: #39419
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@RaisinTen @foxxyz
src: use SPrintF in ProcessEmitWarning
221e75b 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Backport-PR-URL: nodejs#39419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RaisinTen @nodejs-github-bot @jasnell @richardlau @addaleax @joyeecheung @targos