-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: throw error in LoadBuiltinModuleSource when reading fails #38904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource.
github-actions
bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jun 2, 2021
bl-ue
approved these changes
Jun 2, 2021
RaisinTen
reviewed
Jun 2, 2021
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: Darshan Sen <[email protected]>
while you're at it you could also replace the other file reading stuff, like what #31844 has, though that could be separate changes too. |
cc @nodejs/startup can I have some review please? |
legendecas
approved these changes
Jun 8, 2021
legendecas
reviewed
Jun 8, 2021
This comment has been minimized.
This comment has been minimized.
joyeecheung
added a commit
that referenced
this pull request
Jun 10, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
Landed in 8834ec9 |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: #38904 Reviewed-By: Chengzhong Wu <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
- Move the file reading code in LoadBuiltinModuleSource into util.h so that it can be reused by other C++ code, and return an error code from it when there is a failure for the caller to generate an error. - Throw an error when reading local builtins fails in LoadBulitinModuleSource. PR-URL: nodejs#38904 Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
review wanted
PRs that need reviews.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.h so that it can be reused by other C++ code, and
return an error code from it when there is a failure for
the caller to generate an error.
LoadBulitinModuleSource.
The error looks something like this