-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typings: add JSDoc typings for child_process #38222
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JSDoc typings for the `child_process` lib module.
nodejs-github-bot
added
child_process
Issues and PRs related to the child_process subsystem.
needs-ci
PRs that need a full CI run.
labels
Apr 13, 2021
VoltrexKeyva
changed the title
lib: add JSDoc typings for child_process
typings: add JSDoc typings for child_process
Apr 15, 2021
jasnell
approved these changes
Apr 28, 2021
bl-ue
approved these changes
Jun 6, 2021
mhdawson
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mhdawson
pushed a commit
that referenced
this pull request
Jun 17, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: #38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed in 9d3a592 |
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Jun 17, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: nodejs#38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 21, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: #38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: #38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: #38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Added JSDoc typings for the `child_process` lib module. PR-URL: nodejs#38222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
needs-ci
PRs that need a full CI run.
typings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSDoc typings for the
child_process
lib module.