[v14.x] deps: update V8 to 8.4 #34356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
I think that this needs to land with this patch |
4 tasks
|
@MylesBorins #34272 is already part of this PR: 8865013 |
|
@targos I’ve pushed a few changes that should bring this to ABI compatibility :) |
|
I'm prepping a 14.x release today. Should I punt the release by a day or two so we can get this landed? |
|
@MylesBorins I would be in favor of waiting for this to land, yes |
13 tasks
|
@addaleax thanks a lot! It looks like we need to disable some tests that use the @MylesBorins did you mean to push this merge commit? |
|
@targos Ah, yeah, I only ran |
|
I'll try to do it 👍 |
|
@targos I did mean to push that, apologies if it complicated things. There was a conflict due to a V8 change that landed on staging |
|
@MylesBorins I don’t think there are circumstances in Node.js’s development model where merge commits are useful, because they will need to be removed again when rebasing or landing anyway |
|
@addaleax I'll avoid it in the future |
|
Going to delay the release one more day so we can try and get this in, but If we cant get this landed by tomorrow I think we should wait until 14.7.0 which is scheduled to land in 2 weeks |
Merged
13 tasks
Original commit message:
[testrunner] delete ancient junit compatible format support
Testrunner has ancient support for JUnit compatible XML output.
This CL removes this old feature.
[email protected],[email protected],[email protected]
CC=[email protected]
Bug: v8:8728
Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
Reviewed-on: https://chromium-review.googlesource.com/c/1430065
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Michael Starzinger <[email protected]>
Commit-Queue: Tamer Tas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#59045}
Refs: v8/v8@bd019bd
PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fixes a compilation issue on some platforms PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> PR-URL: nodejs#32116 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Original commit message:
Reland "[snapshot] rehash JSMap and JSSet during deserialization"
This is a reland of 8374feed55a5b3010f2e9593560a2d84f9f6725f.
Fixed rehashing of global proxy keys by creating its identity hash
early, before the deserialization of the context snapshot.
Original change's description:
> [snapshot] rehash JSMap and JSSet during deserialization
>
> To rehash JSMap and JSSet, we simply replace the backing store
> with a new one created with the new hash.
>
> Bug: v8:9187
> Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983
> Commit-Queue: Joyee Cheung <[email protected]>
> Reviewed-by: Jakob Gruber <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#67663}
Bug: v8:9187, v8:10523
Change-Id: I7a0319b1d10ff07644de902fec43e7c2b1dd8da9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212085
Reviewed-by: Leszek Swirski <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/master@{#67999}
Refs: v8/v8@22014de
Backport-PR-URL: #34356
PR-URL: #33300
Refs: v8/v8@ea0719b
Refs: v8/v8@bb9f0c2
Refs: #17058
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Original commit message:
[promisehook] Add before/after hooks to thenable tasks
This will allow Node.js to properly track async context in thenables.
Change-Id: If441423789a78307a57ad7e645daabf551cddb57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Sathya Gunasekaran <[email protected]>
Commit-Queue: Gus Caplan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#68207}
Refs: v8/v8@eec10a2
Backport-PR-URL: #34356
PR-URL: #33778
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. Backport-PR-URL: #34356 PR-URL: #33579 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Backport-PR-URL: #34356 PR-URL: #33579 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Bump minimum version of ICU needed to build node to 67. Refs: v8/v8@611e412 Backport-PR-URL: #34356 PR-URL: #33579 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
The postmortem metadata test is no longer used to maintain postmortem debugging tools. Since it frequently breaks on V8 updates, it makes more sense to just remove it. Backport-PR-URL: #34356 PR-URL: #33579 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Refs: v8/v8@9dbab9b PR-URL: #34356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Undoes the ABI-breaking part of v8/v8@92a44876bd66aa. Refs: v8/v8@92a4487 PR-URL: #34356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Original commit message:
[weakrefs] Remove deprecated FinalizationGroup V8 API
Bug: v8:8179
Change-Id: I16170a197028beb35309b15613004b29a956896c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171696
Reviewed-by: Ulan Degenbaev <[email protected]>
Reviewed-by: Ross McIlroy <[email protected]>
Commit-Queue: Ross McIlroy <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#67492}
Refs: v8/v8@de4c004
PR-URL: #34356
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Remove new functionality that interferes with ABI compatibility. PR-URL: #34356 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
This change broke the Specifically
|
This was referenced Jul 17, 2020
This was referenced Jun 17, 2021
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Jul 12, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by nodejs#34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede
richardlau
added a commit
that referenced
this pull request
Jul 15, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
jameshilliard
pushed a commit
to jameshilliard/node
that referenced
this pull request
Jul 19, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by nodejs#34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: nodejs#39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
richardlau
added a commit
that referenced
this pull request
Jul 20, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
richardlau
added a commit
to jameshilliard/node
that referenced
this pull request
Jul 23, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by nodejs#34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: nodejs#39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
richardlau
added a commit
that referenced
this pull request
Jul 23, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Backport-PR-URL: #39451 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
guybedford
pushed a commit
that referenced
this pull request
Jul 26, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Backport-PR-URL: #39451 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
richardlau
added a commit
that referenced
this pull request
Jul 26, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Backport-PR-URL: #39451 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by nodejs#34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: nodejs#39068 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33579
Headers diff: https://gist.github.com/targos/b6f16016f80fa01c328156642c6c0eb4 (
git diff abb5e1a476...HEAD -- deps/v8/include ':(exclude)deps/v8/include/cppgc')This probably needs some changes for ABI compatibility. /cc @nodejs/v8-update @addaleax