-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix name of variable in inspector-cli test #38869
Conversation
Edit: It's already there. I'll run codespell on the tests after this PR and PR the changes, if you don't mind. |
Fast-track has been requested by @lpinca. Please 👍 to approve. |
This should really be landed. Open for over two weeks, 5 approvals, fixes a tiny typo, and fast-track requested for over two weeks. ?? @RaisinTen? |
@bl-ue I'm sorry but node/doc/guides/collaborator-guide.md Line 207 in 58bd046
|
I wonder if they can just be re-run. They look like possible flakes to me (tho I'm not that familiar with the node checks, admittedly). |
I tried restarting the failed runs but they still fail. The issue has already been reported here: #39038 |
I think the reason is that GitHub actions doesn't rebase automatically (unlike Jenkins). |
@tniessen It was happening because https://www.nasm.us/ was down. Now it is up, so the workflows should run as intended now. |
Landed in 5b5a9eb...e7d5f0a |
PR-URL: #38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#38869 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This changes the spelling of the name of the local variable.