Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.17.4 proposal #39466

Merged
merged 140 commits into from
Jul 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
140 commits
Select commit Hold shift + click to select a range
17eb561
deps: V8: backport 1b1eda0876aa
targos Jul 3, 2021
a83b01a
deps: V8: cherry-pick 92e6d3317082
targos Jul 3, 2021
4be2e87
deps: V8: cherry-pick 7c182bd65f42
targos Jul 7, 2021
7fdd6ec
deps: V8: cherry-pick 0b3a4ecf7083
targos Jul 7, 2021
a60a960
deps: V8: cherry-pick 895949419186
targos Jul 7, 2021
7557e74
deps: V8: update build dependencies
targos Jul 7, 2021
ccecea5
deps: restore minimum ICU version to 65
richardlau Jun 17, 2021
4213e97
deps: V8: cherry-pick 81181a8ad80a
thomasmichaelwallace Jun 28, 2021
8bd2a39
debugger: move node-inspect to internal library
Trott Apr 8, 2021
fc219d8
tools: remove node-inspect from license
Trott Apr 8, 2021
0321c5b
debugger: remove unused code
Trott Apr 8, 2021
1da6921
debugger: fix inspect restart on Windows
Trott Apr 20, 2021
b172e6f
debugger: accommodate line chunking in Windows
Trott Apr 21, 2021
22afb7c
debugger: allow longer time to connect
Trott Apr 21, 2021
193ea8f
test: fix test-inspector-cli-address
Trott Apr 22, 2021
a62826b
test,debugger: migrate node-inspect tests to core
Trott Apr 9, 2021
a8924fa
debugger: replace internal use of deprecated API
Trott Apr 20, 2021
dd2642b
test: fix comment typo
Trott Apr 22, 2021
9e28c6c
debugger: fix race condition/deadlock on initialization
Trott Apr 23, 2021
4d3a1fa
test: extend timeout on debugger tests for slower machines
Trott Apr 23, 2021
99fd8bf
test: fix flaky inspector-cli tests when breakpionts are restored
Trott Apr 27, 2021
4d9129e
doc: update code examples for `node:url` module
fisker May 12, 2021
7d82200
src: replace `auto`s in node_contextify.cc
XadillaX May 12, 2021
e265d8e
test: give js-native-api tests consistent names
gabrielschulhof May 14, 2021
8049b69
doc: document null target pattern
guybedford May 18, 2021
846a138
src: write named pipe info in diagnostic report
legendecas May 11, 2021
2c11d3e
src: remove commented code in `node_file.cc`
juanarbol May 15, 2021
2d32031
src: use HandleScope in StreamReq::Done()
RaisinTen May 17, 2021
6ea1368
typings: add JSDoc typings for events
VoltrexKeyva May 17, 2021
aeea252
test: improve coverage of lib/_http_outgoing.js
pd4d10 May 19, 2021
b5b1d1f
build: replace non-POSIX test -a|o
concatime May 19, 2021
f9693cf
benchmark: fix http elapsed time
aduh95 May 20, 2021
55ea29e
child_process: retain reference to data with advanced serialization
addaleax May 18, 2021
58154ce
typings: add JSDoc typings for https
VoltrexKeyva May 8, 2021
a6f8ba8
build: allow LTO with Clang 3.9.1+
jesec May 21, 2021
826ae9b
doc: fixup code sample in http.md
todortotev May 22, 2021
eb91932
test: os, replace custom flatten method with built-in Array.flat
waelsy123 May 22, 2021
86477b2
benchmark: output JSON-compatible numbers
targos May 23, 2021
504bfd7
test: improve coverage for `question` in readline
Ayase-252 May 24, 2021
8699e62
doc: fix grammar in `fs.md`
yotamselementor May 26, 2021
01f00fa
test: simplify test-path-resolve.js
himself65 May 13, 2021
7f53a0b
build: add lto build to CI
gengjiawen May 6, 2021
fecad40
test: fix writefile with fd
Linkgoron May 26, 2021
1dc71da
tools: update setup-node to setup-node@v2
JayFate May 27, 2021
dfe9698
doc: use "Long Term Support" in README
phershbe May 29, 2021
7a9850a
doc: use "Long Term Support" in technical values doc
Trott May 29, 2021
b4f60bb
doc: use "Long Term Support" in collaborator guide
Trott May 29, 2021
2ec7c9d
tools: remove exception for Node.js 8 and earlier
Trott May 29, 2021
b7686d0
tools: bump cpplint to 1.5.5
Trott May 30, 2021
2ad0719
tools: refloat 7 Node.js patches to cpplint.py
Trott Oct 9, 2020
fb0ab4c
debugger: removed unused function argument
Trott May 30, 2021
e36d2a6
doc: fixed typo in n-api.md
julianjany May 27, 2021
73e199d
src: fix typos
bl-ue May 29, 2021
b0a1984
lib: fix typos
bl-ue May 31, 2021
981217e
src: replace `auto`s in node_api.cc
XadillaX May 30, 2021
0cca16a
test: improve coverage of fs internal utils
pd4d10 May 20, 2021
1ffbe3d
build: remove outdated dont-land-on-v6.x label
targos Jun 1, 2021
2c28e00
worker: do not look up context twice in PostMessage
addaleax May 23, 2021
ff7cc8f
src: add not-weak DCHECK to PersistentToLocal::Strong
addaleax May 31, 2021
4bb0bd0
tools,doc: forbid CJS globals in ESM code snippets
aduh95 Jun 1, 2021
b2d836b
doc: clarify when `readable._read(...)` is called
sploders101 May 18, 2021
9b4ae8f
tools: bump remark-preset-lint-node to 2.3.0
Trott Jun 2, 2021
49a0006
build: correct Xcode spelling in .gitignore
bl-ue Jun 1, 2021
fc2b1ec
child_process: refactor to use `validateBoolean`
Ayase-252 Jun 4, 2021
dd00547
vm: use missing validator
VoltrexKeyva Jun 4, 2021
6c061d5
meta: update label-pr-config
targos Jun 6, 2021
cd3305a
node-api: avoid SecondPassCallback crash
mhdawson Jun 2, 2021
660a97b
test: suppress warning in test_environment.cc
danbev May 31, 2021
0736dd8
build: don't pass python override to V8 build
richardlau Jun 8, 2021
b405296
doc: mark util.inherits as legacy
VoltrexKeyva Jun 1, 2021
b6942a6
url,src: simplify ipv6 logic by using uv_inet_pton
XadillaX May 29, 2021
bee477b
src: throw error in LoadBuiltinModuleSource when reading fails
joyeecheung May 28, 2021
8dd1f70
debugger: apply automatic lint fixes for _inspect.js
Trott Apr 26, 2021
61da371
debugger: apply automatic lint fixes for inspect_repl.js
Trott Apr 26, 2021
1023433
tools: update ESLint to 7.28.0
lpinca Jun 7, 2021
d341561
build: fix commit-queue default branch
mmarchini Jun 10, 2021
41fcbad
doc: add missing semis after classes
RaisinTen Jun 4, 2021
c99a09f
test: http outgoing _headers setter null
ycjcl868 Jun 1, 2021
cd48ee7
doc: fixed typo in process.md
maks-der Jun 5, 2021
b3b5995
test: improve coverage of lib/events.js
pd4d10 May 7, 2021
547f88b
tools: fix typo in commit-queue.sh
bl-ue Jun 10, 2021
e474e98
doc: clarify that only one Python version is required to build
bl-ue Jun 1, 2021
443db64
tools: avoid crashing CQ when git push fails
aduh95 Jan 10, 2021
069cf59
build: make build-addons errors fail the build
richardlau Jun 9, 2021
ab28f9b
test: remove obsolete TLS test
Trott Jun 11, 2021
afb6178
module: fix legacy `node` specifier resolution to resolve `"main"` field
aduh95 Jun 9, 2021
797bd73
doc: add missing parameter types
VoltrexKeyva Jun 12, 2021
dcfb182
src: refactor to use locale functions
RaisinTen Jun 12, 2021
54a250e
tools: update doctool dependencies, migrate to ESM
targos Jun 8, 2021
6962c64
Revert "build: work around bug in MSBuild v16.10.0"
targos Jun 9, 2021
4009350
test: fix typo
houssemchebeb Jun 15, 2021
6f1862e
test: fix name of variable in inspector-cli test
tniessen May 31, 2021
43fe6c1
src: cleanup uv_fs_t regardless of success or not
legendecas Jun 10, 2021
51da7d2
src,url: separate some tables out of node_url.cc
XadillaX Jun 10, 2021
04032fa
doc: remove references to deleted freenode channels
devsnek Jun 15, 2021
2bc2a23
lib: add JSDoc typings for child_process
VoltrexKeyva Apr 13, 2021
6447cab
test: improve buffer coverage
pd4d10 May 4, 2021
6b2fea3
test: move inspector-cli tests to sequential
Trott Jun 19, 2021
4c2b813
debugger: rename internal library for clarity
Trott Jun 19, 2021
a657f25
build: reconfigure when gyp files change on Windows
joyeecheung Jun 17, 2021
199fe32
lib: make internal/options lazy
joyeecheung Jun 10, 2021
b8e63b3
tools: update ESLint to 7.29.0
Trott Jun 19, 2021
097a787
lib: remove semicolon in preparation for babel/eslint-parser update
Trott Jun 19, 2021
ab45ace
tools: update babel-eslint-parser to 7.14.5
Trott Jun 19, 2021
bb9a9ad
errors: don't rekey on primitive type
bcoe Jun 13, 2021
e7f266e
src: use SPrintF in ProcessEmitWarning
RaisinTen May 21, 2021
1ab4f81
build: fix building with external builtins
mmomtchev Jun 19, 2021
ea9003a
lib: add `globalThis` to primordials
aduh95 Apr 12, 2021
d4f96bb
lib: enforce using `primordials.globalThis` instead of `global`
aduh95 Apr 13, 2021
e3223ed
lib: harden lint checks for globals
aduh95 Apr 26, 2021
9b69069
deps: V8: cherry-pick b0a7f5691113
targos Jun 16, 2021
45c2ea3
test: add NumberFormat resolvedOptions test
richardlau Jul 15, 2021
5039f21
deps: V8: backport 16ffec97e5eb
targos Jul 20, 2021
4efefe0
deps: V8: backport ae7bfb3f03b3
targos Jul 20, 2021
d8cc2ff
lib: add primordials.SafeArrayIterator
aduh95 Dec 6, 2020
cde7221
Revert "debugger: rename internal library for clarity"
aduh95 Jul 20, 2021
21ecee1
debugger: add usage example for `--port`
RafaelGSS Jul 27, 2020
721edef
debugger: refactor `internal/inspector/_inspect` to use more primordials
aduh95 Apr 25, 2021
79bfb04
debugger: wait for V8 debugger to be enabled
targos May 26, 2021
0ef5e08
debugger: revise async iterator usage to comply with lint rules
Trott May 29, 2021
249acd5
debugger: reduce scope of eslint disable comment
Trott Jun 6, 2021
e58f938
debugger: enable linter on `internal/inspector/inspect_client`
aduh95 Apr 26, 2021
d74d67f
debugger: remove unnecessary boilerplate copyright comment
Trott Jun 6, 2021
b30ff35
debugger: align message with Node.js standard
Trott Sep 19, 2020
ae90756
debugger: wrap lines longer than 80 chars
Trott May 4, 2021
34659f2
debugger: avoid non-ASCII char in code file
Trott May 4, 2021
b5724a1
debugger: disable only the lint rules required by current file state
Trott May 4, 2021
ad80566
debugger: refactor to use internal modules
aduh95 May 5, 2021
f9a4dcb
debugger: refactor `inspect_repl` to use primordials
aduh95 Apr 27, 2021
052e1c5
debugger: removed unused function argument
Trott May 30, 2021
cfccf13
errors: add ERR_DEBUGGER_ERROR
Trott Jun 13, 2021
a3991d7
debugger: use ERR_DEBUGGER_ERROR in debugger client
Trott Jun 13, 2021
5d4d23d
debugger: use error codes in debugger REPL
Trott Jun 13, 2021
9b993ed
errors: add ERR_DEBUGGER_STARTUP_ERROR
Trott Jun 13, 2021
b7ee9d8
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
Trott Jun 13, 2021
716ee15
debugger: rename internal library for clarity
Trott Jun 19, 2021
2ff671e
doc,url: clarify domainTo* when built without ICU
RaisinTen May 23, 2021
d48b91e
http2: on receiving rst_stream with cancel code add it to pending list
kumarak Jul 17, 2021
acf5279
deps: upgrade npm to 6.14.14
darcyclarke Jul 27, 2021
488c27f
2021-07-29, Version 14.17.4 'Fermium' (LTS)
richardlau Jul 20, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
28 changes: 24 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ Module._findPath = (request, paths, isMain) => {
if (!r && hacks.includes(request)) {
try {
return require.resolve(`./tools/node_modules/${request}`);
// Keep the variable in place to ensure that ESLint started by older Node.js
// versions work as expected.
// eslint-disable-next-line no-unused-vars
} catch (e) {
} catch {
return require.resolve(
`./tools/node_modules/eslint/node_modules/${request}`);
}
Expand Down Expand Up @@ -79,6 +76,29 @@ module.exports = {
'doc/api/packages.md/*.js',
],
parserOptions: { sourceType: 'module' },
rules: { 'no-restricted-globals': [
'error',
{
name: '__filename',
message: 'Use import.meta.url instead',
},
{
name: '__dirname',
message: 'Not available in ESM',
},
{
name: 'exports',
message: 'Not available in ESM',
},
{
name: 'module',
message: 'Not available in ESM',
},
{
name: 'require',
message: 'Use import instead',
},
] },
},
],
rules: {
Expand Down
2 changes: 1 addition & 1 deletion .github/SUPPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ resources:

* [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
* [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) channel on the OpenJS Foundation Slack ([join here](https://slack-invite.openjsf.org/))
* [#node.js channel on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
* [#node.js channel on libera.chat](https://web.libera.chat?channels=node.js&uio=d4)
* [Node.js Slack Community](https://node-js.slack.com/)
* To register: [nodeslackers.com](https://www.nodeslackers.com/)

Expand Down
57 changes: 29 additions & 28 deletions .github/label-pr-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,31 @@ subSystemLabels:
/^src\/udp_/: c++, dgram
/^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs
/^src\/node_http_parser/: c++, http_parser
/^src\/node_i18n/: c++, intl
/^src\/node_i18n/: c++, i18n-api
/^src\/uv\./: c++, libuv
/^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net
/^src\/node_os/: c++, os
/^src\/(?:node_main|signal_)/: c++, process
/^src\/timer_/: c++, timers
/^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls
/^src\/tty_/: c++, tty
/^src\/node_url/: c++, url-whatwg
/^src\/node_url/: c++, whatwg-url
/^src\/node_util/: c++, util
/^src\/(?:node_v8|v8abbr)/: c++, V8 Engine
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
/^src\/node_contextify/: c++, vm
/^src\/.*win32.*/: c++, windows
/^src\/node_zlib/: c++, zlib
/^src\/tracing/: c++, tracing
/^src\/node_api/: c++, n-api
/^src\/node_http2/: c++, http2, dont-land-on-v6.x
/^src\/node_api/: c++, node-api
/^src\/node_http2/: c++, http2
/^src\/node_report/: c++, report
/^src\/node_wasi/: c++, wasi
/^src\/node_worker/: c++, worker
/^src\/quic\/*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
/^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x

# don't label python files as c++
/^src\/.+\.py$/: lib / src, needs-ci
/^src\/.+\.py$/: python, needs-ci

# properly label changes to v8 inspector integration-related files
/^src\/inspector_/: c++, inspector, needs-ci
Expand All @@ -50,23 +50,24 @@ subSystemLabels:
/^\w+\.md$/: doc
# different variants of *Makefile and build files
/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, needs-ci
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
/^vcbuild\.bat$/: build, windows, needs-ci
/^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
# more specific tools
/^tools\/gyp/: tools, build, needs-ci
/^tools\/gyp/: tools, build, gyp, needs-ci
/^tools\/doc\//: tools, doc
/^tools\/icu\//: tools, intl, needs-ci
/^tools\/icu\//: tools, i18n-api, icu, needs-ci
/^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
/^tools\/(?:(?:mac)?osx-)/: tools, macos
/^tools\/test-npm/: tools, test, npm
/^tools\/test/: tools, test
/^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls
/^tools\/msvs\//: tools, windows, install, needs-ci
/^tools\/[^/]+\.bat$/: tools, windows, needs-ci
/^tools\/make-v8/: tools, V8 Engine, needs-ci
/^tools\/(code_cache|snapshot|v8_gypfiles)/: needs-ci,
/^tools\/build-addons.js/: needs-ci,
/^tools\/make-v8/: tools, v8 engine, needs-ci
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
/^tools\/(code_cache|snapshot)/: needs-ci
/^tools\/build-addons.js/: needs-ci
# all other tool changes should be marked as such
/^tools\//: tools
/^\.eslint|\.remark|\.editorconfig/: tools
Expand All @@ -75,11 +76,12 @@ subSystemLabels:
# libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
# end up as libuv changes labeled with "uv" (which is a non-existing label)
/^deps\/uv\//: libuv
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem
/^deps\/v8\//: V8 Engine
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
/^deps\/v8\//: v8 engine
/^deps\/uvwasi\//: wasi
/^deps\/nghttp2\/nghttp2\.gyp/: build, http2, dont-land-on-v6.x
/^deps\/nghttp2\//: http2, dont-land-on-v6.x
/^deps\/npm\//: npm, fast-track
/^deps\/nghttp2\/nghttp2\.gyp/: build, http2
/^deps\/nghttp2\//: http2
/^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
/^deps\/nghttp3\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
/^deps\/([^/]+)/: $1
Expand All @@ -94,10 +96,10 @@ subSystemLabels:
/^lib\/\w+\/v8_prof_/: tools
/^lib\/\w+\/socket_list/: net
/^lib\/\w+\/streams$/: stream
/^lib\/.*http2/: http2, dont-land-on-v6.x
/^lib\/.*http2/: http2
/^lib\/worker_threads.js$/: worker
/^lib\/internal\/url\.js$/: url-whatwg
/^lib\/internal\/modules\/esm/: ES Modules
/^lib\/internal\/url\.js$/: whatwg-url
/^lib\/internal\/modules\/esm/: esm
/^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x

# All other lib/ files map directly
Expand All @@ -114,24 +116,22 @@ exlusiveLabels:
/^test\/pseudo-tty\//: test, tty
/^test\/inspector\//: test, inspector
/^test\/cctest\/test_inspector/: test, inspector
/^test\/cctest\/test_url/: test, url-whatwg
/^test\/addons-napi\//: test, n-api
/^test\/cctest\/test_url/: test, whatwg-url
/^test\/addons-napi\//: test, node-api
/^test\/async-hooks\//: test, async_hooks
/^test\/report\//: test, report
/^test\/fixtures\/es-module/: test, ES Modules
/^test\/es-module\//: test, ES Modules
/^test\/fixtures\/es-module/: test, esm
/^test\/es-module\//: test, esm

/^test\//: test

# specific map for webcrypto.md as it should be labeled 'crypto'
/^doc\/api\/webcrypto.md$/: doc, crypto
# specific map for modules.md as it should be labeled 'module' not 'modules'
/^doc\/api\/modules.md$/: doc, module
# specific map for esm.md as it should be labeled 'ES Modules' not 'esm'
/^doc\/api\/esm.md$/: doc, ES Modules
# n-api is treated separately since it is not a JS core module but is still
# node-api is treated separately since it is not a JS core module but is still
# considered a subsystem of sorts
/^doc\/api\/n-api.md$/: doc, n-api
/^doc\/api\/n-api.md$/: doc, node-api
# quic
/^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
# add worker label to PRs that affect doc/api/worker_threads.md
Expand All @@ -140,12 +140,13 @@ exlusiveLabels:
/^doc\/api\/(\w+)\.md$/: doc, $1
# add deprecations label to PRs that affect doc/api/deprecations.md
/^doc\/api\/deprecations.md$/: doc, deprecations
/^doc\/changelogs\//: release

/^doc\//: doc

# more specific benchmarks
/^benchmark\/buffers\//: benchmark, buffer
/^benchmark\/(?:arrays|es)\//: benchmark, V8 Engine
/^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
/^benchmark\/_http/: benchmark, http
/^benchmark\/(?:misc|fixtures)\//: benchmark
/^benchmark\/streams\//: benchmark, stream
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
Expand All @@ -45,6 +45,7 @@ jobs:
run: |
echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
echo "DEFAULT_BRANCH=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV

- name: Get Pull Requests
uses: octokit/[email protected]
Expand All @@ -63,19 +64,19 @@ jobs:
owner: ${{ env.OWNER }}
repo: ${{ env.REPOSITORY }}
# Commit queue is only enabled for the default branch on the repository
base_ref: ${{ github.repository.default_branch }}
base_ref: ${{ env.DEFAULT_BRANCH }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Configure node-core-utils
run: |
ncu-config set branch ${{ github.repository.default_branch }}
ncu-config set branch ${DEFAULT_BRANCH}
ncu-config set upstream origin
ncu-config set username "${{ secrets.GH_USER_NAME }}"
ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
ncu-config set jenkins_token "${{ secrets.JENKINS_TOKEN }}"
ncu-config set repo "${{ env.REPOSITORY }}"
ncu-config set owner "${{ env.OWNER }}"
ncu-config set repo "${REPOSITORY}"
ncu-config set owner "${OWNER}"

- name: Start the commit queue
run: ./tools/actions/commit-queue.sh ${{ env.OWNER }} ${{ env.REPOSITORY }} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
28 changes: 28 additions & 0 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Node.js daily job

on:
workflow_dispatch:
schedule:
- cron: "0 0 * * *"

env:
NODE_VERSION: 14.x

jobs:
build-lto:
runs-on: ubuntu-latest
# not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
container: gcc:11
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build lto
run: |
apt-get update && apt-get install ninja-build python-is-python3 -y
./configure --enable-lto --ninja
ninja -C out/Release
6 changes: 3 additions & 3 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand All @@ -43,7 +43,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand All @@ -57,7 +57,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ tools/*/*.i.tmp
/build
/coverage

# === Rules for XCode artifacts ===
# === Rules for Xcode artifacts ===
*.xcodeproj
*.xcworkspace
*.pbxproj
Expand Down
4 changes: 2 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ test with Python 3.
* GNU Make 3.81 or newer
* Python (see note above)
* Python 2.7
* Python 3.5, 3.6, 3.7, and 3.8
* Python 3.5, 3.6, 3.7, or 3.8

Installation via Linux package manager can be achieved with:

Expand All @@ -255,7 +255,7 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`.
* Xcode Command Line Tools >= 10 for macOS
* Python (see note above)
* Python 2.7
* Python 3.5, 3.6, 3.7, and 3.8
* Python 3.5, 3.6, 3.7, or 3.8

macOS users can install the `Xcode Command Line Tools` by running
`xcode-select --install`. Alternatively, if you already have the full Xcode
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.3">14.17.3</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.4">14.17.4</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.17.3">14.17.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.17.2">14.17.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.17.1">14.17.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.17.0">14.17.0</a><br/>
Expand Down
23 changes: 0 additions & 23 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -1333,29 +1333,6 @@ The externally maintained libraries used by Node.js are:
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
"""

- node-inspect, located at deps/node-inspect, is licensed as follows:
"""
Copyright Node.js contributors. All rights reserved.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal in the Software without restriction, including without limitation the
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.
"""

- large_pages, located at src/large_pages, is licensed as follows:
"""
Copyright (C) 2018 Intel Corporation
Expand Down
Loading