Skip to content

[FIXED] Filestore don't add deletes for empty block with SkipMsgs#7401

Merged
neilalexander merged 1 commit intomainfrom
maurice/fs-empty-skip-deletes
Oct 8, 2025
Merged

[FIXED] Filestore don't add deletes for empty block with SkipMsgs#7401
neilalexander merged 1 commit intomainfrom
maurice/fs-empty-skip-deletes

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Follow-up of #7399, when a block contains multiple SkipMsgs and is empty at the start (or fully), then these should not be added as deleted messages to the dmap.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner October 7, 2025 09:30
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 0a64870 into main Oct 8, 2025
153 of 158 checks passed
@neilalexander neilalexander deleted the maurice/fs-empty-skip-deletes branch October 8, 2025 08:44
neilalexander added a commit that referenced this pull request Oct 10, 2025
Includes the following:

- #7400
- #7399
- #7401
- #7402
- #7404
- #7405
- #7409
- #7413

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Oct 28, 2025
Includes the following:

- #7380
- #7384
- #7385
- #7388
- #7395
- #7400
- #7399
- #7401
- #7402
- #7423
- #7424
- #7411
- #7428
- #7429
- #7431
- #7435
- #7433
- #7443
- #7455
- #7465
- #7466
- #7460
- #7484
- #7479

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants