Always use temporary staging for filestore meta file writes#7388
Merged
neilalexander merged 1 commit intomainfrom Oct 2, 2025
Merged
Always use temporary staging for filestore meta file writes#7388neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
neilalexander
force-pushed
the
neil/fspivot
branch
from
98fbfc6 to
54bf137
Compare
sciascid
requested changes
Oct 2, 2025
neilalexander
force-pushed
the
neil/fspivot
branch
from
54bf137 to
bd0965e
Compare
Contributor
|
I was going to suggest something similar. In the end I didn't, because I thought that the current approach may work for small files, like Raft's term and vote file for example. As single sector overwrites are typically atomic. This may be an interesting read: https://www.usenix.org/system/files/conference/osdi14/osdi14-paper-pillai.pdf |
sciascid
reviewed
Oct 2, 2025
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/fspivot
branch
from
bd0965e to
710407c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides better crash-resilience during interrupted filesystem operations, i.e. where writing
meta.inf/meta.sum/index.dbis interrupted withO_TRUNCleaving behind an empty file.Signed-off-by: Neil Twigg neil@nats.io