[FIXED] Filestore detect delete gap with last SkipMsg#7399
Merged
neilalexander merged 1 commit intomainfrom Oct 7, 2025
Merged
[FIXED] Filestore detect delete gap with last SkipMsg#7399neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/fs-skip-gap
branch
from
0ec8465 to
bcfbfb8
Compare
neilalexander
added a commit
that referenced
this pull request
Oct 8, 2025
) Follow-up of #7399, when a block contains multiple `SkipMsgs` and is empty at the start (or fully), then these should not be added as deleted messages to the dmap. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there was a gap in messages in the filestore, and the very last message was an erased message it would not register these as deletes properly. This would then result in a all kinds of issues: constant cache invalidation, slow reads/catchup, and generally the filestore not knowing these messages were deleted.
Signed-off-by: Maurice van Veen github@mauricevanveen.com