Skip to content

Document exportTo restrictions#816

Closed
frankbu wants to merge 30 commits intorelease-1.1from
export_to
Closed

Document exportTo restrictions#816
frankbu wants to merge 30 commits intorelease-1.1from
export_to

Conversation

@frankbu
Copy link
Contributor

@frankbu frankbu commented Feb 25, 2019

No description provided.

rshriram and others added 27 commits November 14, 2018 08:06
@rshriram @istio-testing
[Cherry-pick]Adding weights to service entry endpoints (#704) (#706)
93b99d4 
* Adding weights to service entry endpoints (#704)

* add dynamic state to attribute list

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Adding weights to service entry endpoints

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* undo

* update protolock

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@vadorovsky @istio-testing
bazel: Allow to distdir all dependencies (#702)
4eeb69c 
To use --distdir option of Bazel (which allows to use previously
fetched tarballs instead of downloading dependencies during
build), all dependencies should use http instead of git and need
to have sha256 sums specified.

Signed-off-by: Michal Rostecki <mrostecki@suse.de>
@GregHanson @istio-testing
add access log encoding (#710)
62032e0
@hklai
Merge remote-tracking branch 'upstream/release-1.1' into 1.1-master
a6e0c12
@hklai
Merge pull request #721 from hklai/1.1-master
a4f4a1f 
 Merge release-1.1 into master
@pilhuhn @frankbu
target -> targets (#725)
b917615
@jeffmendoza @rshriram
Add note to readme about backwards incompatible changes (#700)
6a495cf
@geeknoid
Fix a comment. (#739)
c85aada
Comment typo fixes.
73238e1
@hklai
Merge release-1.1 into master
a999ccd
@hklai
Merge pull request #750 from hklai/1.1-master
5762965 
 Merge release-1.1 into master
@geeknoid
Comment fixes. (#751)
056eb85
@yangminzhu
Merge branch 'release-1.1' to Master
1c71953
@rshriram
Merge pull request #759 from yangminzhu/merge-1-1
40a08a3 
Merge release-1.1 into master
@hklai
Merge release-1.1 into master (#766)
a222b70 
* assorted doc updates (#757)

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add optional incremental flag to ResponseSink and ResourceSource services (#762)

* Add option to select worload using lables for authn policy. (#755)

* Add option to select workload using labels for authn policy

* Make proto-commit
@hklai
Merge remote-tracking branch 'upstream/release-1.1' into 1.1-master
c26350e
@hklai
Merge pull request #768 from hklai/1.1-master
827080d 
Merge release-1.1 master
@hklai
add response headers (#769) (#771)
d0444f6 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@hklai
Merge remote-tracking branch 'upstream/release-1.1' into 1.1-master
35daa9d
@hklai
Merge pull request #774 from hklai/1.1-master
825044c 
Merge release-1.1 into master. (Final batch)
@howardjohn @geeknoid
Fix typos in sidecar.proto (#795)
01a2afd
@cgilmour @geeknoid
Generate files with correct owner. (#798)
2b2fabd 
Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
@cgilmour @istio-testing
Add Datadog tracing to proxy config (#797)
f6b6c41 
Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
Merge branch 'release-1.1' into Merge11ToMaster
823a224
Merge pull request #806 from louiscryan/Merge11ToMaster
53b11a3 
Merge 1.1 to master
@sebastienvas @geeknoid
Remove myself from owners add utka instead (#814)
f0270ae
@frankbu
Document exportTo restrictions
3dd0d12
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 25, 2019
@istio-testing
Copy link
Collaborator

istio-testing commented Feb 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andraxylia
andraxylia reviewed Feb 26, 2019
View reviewed changes
andraxylia
andraxylia reviewed Feb 26, 2019
View reviewed changes
networking/v1alpha3/destination_rule.proto
// the destination rule is declared in. Similarly, the value "*" is reserved and
// defines an export to all namespaces.
//
// NOTE: in the current release, the `exportTo` value is restricted to
Copy link
Contributor

@andraxylia andraxylia Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: in the current release, the `exportTo` value is restricted to
// NOTE: in the current release, the `export_to` value is restricted to

Copy link
Contributor Author

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the camelCase in comments so they look right in the generated doc.

Copy link
Contributor

@andraxylia andraxylia Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

andraxylia
andraxylia reviewed Feb 26, 2019
View reviewed changes
networking/v1alpha3/service_entry.proto
// the annotation "networking.istio.io/exportTo" to a comma-separated list
// of namespace names.
//
// NOTE: in the current release, the `exportTo` value is restricted to
Copy link
Contributor

@andraxylia andraxylia Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: in the current release, the `exportTo` value is restricted to
// NOTE: in the current release, the `export_to` value is restricted to

andraxylia
andraxylia reviewed Feb 26, 2019
View reviewed changes
networking/v1alpha3/virtual_service.proto
// the virtual service is declared in. Similarly, the value "*" is reserved and
// defines an export to all namespaces.
//
// NOTE: in the current release, the `exportTo` value is restricted to
Copy link
Contributor

@andraxylia andraxylia Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: in the current release, the `exportTo` value is restricted to
// NOTE: in the current release, the `export_to` value is restricted to

@googlebot
Copy link
Collaborator

googlebot commented Feb 26, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Feb 26, 2019
@istio-testing
Copy link
Collaborator

istio-testing commented Feb 26, 2019

@frankbu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/api-presubmit.sh 2bfb918 link /test api-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu
Copy link
Contributor Author

frankbu commented Feb 26, 2019

Merged the wrong branch. Closing this one and opening new PR.

@frankbu frankbu closed this Feb 26, 2019
@frankbu frankbu deleted the export_to branch February 26, 2019 15:31
@frankbu frankbu mentioned this pull request Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshriram rshriram Awaiting requested review from rshriram

1 more reviewer

@andraxylia andraxylia andraxylia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.