fix naming convention between access log format vs encoding#710
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 19, 2018
Merged
fix naming convention between access log format vs encoding#710istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
googlebot
added
the
cla: yes
Member
Author
|
related to istio/istio#10056 |
GregHanson
force-pushed
the
access_log_encoding
branch
from
26a059a to
7805a56
Compare
ozevren
reviewed
Nov 19, 2018
mesh/v1alpha1/config.proto
Outdated
|
|
||
| // Encoding for the proxy access log (text or json). | ||
| // Default value is text. | ||
| string access_log_encoding = 27; |
Contributor
There was a problem hiding this comment.
Shouldn't this be an enum?
Contributor
There was a problem hiding this comment.
Makes sense for this to be enum.
The other PR probably is merged by now, so needs the same fix ...
GregHanson
changed the title
istio-testing
added
the
do-not-merge/work-in-progress
GregHanson
changed the title
istio-testing
removed
the
do-not-merge/work-in-progress
GregHanson
force-pushed
the
access_log_encoding
branch
from
d793d2a to
e89d7ea
Compare
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GregHanson, mandarjog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.