Skip to content

Generate files with correct owner#798

Merged
geeknoid merged 1 commit intoistio:masterfrom
DataDog:cgilmour/fix-generated-file-owner
Feb 15, 2019
Merged

Generate files with correct owner#798
geeknoid merged 1 commit intoistio:masterfrom
DataDog:cgilmour/fix-generated-file-owner

Conversation

@cgilmour
Copy link
Contributor

When preparing modifications to this repo, the pre-commit hook uses docker to run some containers and tools to generate code.
The files produced in those steps end up being owned by root instead of the current user.
This causes some problems, eg: when switching branches.
It can be manually cleaned up with sudo chown -R "$USER" .

This change makes sure the generated files are owned by the current user instead, avoiding the problem and cleanup.

Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgilmour
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 14, 2019
@istio-testing
Copy link
Collaborator

Hi @cgilmour. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid geeknoid merged commit 2b2fabd into istio:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants