Skip to content

Fix typos in sidecar.proto#795

Merged
geeknoid merged 2 commits intoistio:masterfrom
howardjohn:patch-1
Feb 13, 2019
Merged

Fix typos in sidecar.proto#795
geeknoid merged 2 commits intoistio:masterfrom
howardjohn:patch-1

Conversation

@howardjohn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 13, 2019
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov

If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

Hi @howardjohn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid
Copy link
Contributor

Could you also make this change in the 1.1 branch (assuming the same text is there)?

Thanks.

@geeknoid
Copy link
Contributor

You need to run "make" before submitting the PR so that the (unforutnately) checked in generated files are correctly updated. Doing so will fix the CI failures.

@howardjohn
Copy link
Member Author

Sure, here is the PR for 1.1 #796

@geeknoid geeknoid merged commit 01a2afd into istio:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants